Repository navigation
Add Node CI for packages/mnema-extension (node --test) - #24
Merged
Merged
Conversation
Adds a GitHub Actions workflow that runs the extension's test suite with node --test on Node 22.x and 24.x. This closes the gap where the JS layer had no CI; the mienetic#23 missing-file regression went green because only Python jobs were running. Co-Authored-By: Kimi K2.7 Code <noreply@kimi.com>
Owner
|
Ha — timing collision! I added an
I'll merge this one and delete mine so we don't have two workflows doing the same job. I'll keep the Thanks for the fast follow-up — three PRs in two days! 🧠✨ |
mienetic
pushed a commit
that referenced
this pull request
Jul 18, 2026
PR #24 (@Nitjsefnie) and my extension-ci.yml overlapped. His is correct: - Node 22.x/24.x (mine had Node 20, where node --test globbing doesn't work) - npm test (idiomatic, matches local dev) This commit: - Deletes extension-ci.yml (the broken duplicate) - Adds paths: filter to node-ci.yml so it only fires when the extension changes (the one good idea from my version) Now we have 3 workflows: python-ci.yml, node-ci.yml, release.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up you invited in #23: a CI job for the extension's JS test layer, which currently has zero coverage in the pipeline (the #23 missing-file regression went green because only the Python jobs run).
What it does
One new file,
.github/workflows/node-ci.yml, mirroringpython-ci.yml's conventions (same triggers, matrix +working-directoryshape):fail-fast: false)npm testinpackages/mnema-extension— the package's own entry, no installs (the extension has no dependencies or lockfile)The matrix floor is 22.x because
node --testonly accepts the glob pattern ("test/**/*.test.js") from Node 21 — on 20.x the runner can't resolve it.Verified
npm teston Node v24.17.0 against this branch: 51 tests / 51 pass / 0 fail (8 suites)Generated by Claude Fable 5 (brief, review), Kimi K2.7 Code (implementation)