chore(deps): route dependabot/renovate PRs to canonical bot:* labels - #2025
chore(deps): route dependabot/renovate PRs to canonical bot:* labels#2025chrisferry wants to merge 5 commits into
Conversation
Dependabot's default labels (dependencies, github_actions, ...) diverge from the org label standard; label each ecosystem bot:dependencies / bot:github-actions. Assisted-by: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a8e13bc02
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - package-ecosystem: "cargo" | ||
| labels: | ||
| - "bot:dependencies" |
There was a problem hiding this comment.
Preserve the changes-check exemption for dependency PRs
For Cargo, npm, and Docker updates, this custom label replaces Dependabot's default dependencies label with only bot:dependencies, but .github/workflows/changes_check.yml lines 85 and 98 still exempt only the exact dependencies and renovate labels. Consequently, bot PRs that touch non-ignored files such as Cargo.lock and lack a change file will run the link check and exit with status 1; update the workflow's exemptions as part of this label migration.
Useful? React with 👍 / 👎.
changes_check matches labels with contains() over a fromJSON array, which is an exact element match, so 'dependencies' does not match 'bot:dependencies'. Routing Dependabot to the canonical labels would therefore have dropped the exemption and failed the link check on bot PRs touching non-ignored files. The legacy names stay listed for now: both label sets currently exist on the repo, so in-flight bot PRs still carry the old ones. Assisted-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Chris Ferry <chris.ferry@shielded.io>
|
Codex P1 applied — the finding was correct and would have broken CI on every bot PR. Verified the mechanism before fixing: Both I kept the legacy
|
Required by the changes check, which wants both a PR link and an issue link. DCO Remediation Commit for Chris Ferry <chris.ferry@shielded.io> I, Chris Ferry <chris.ferry@shielded.io>, hereby add my Signed-off-by to this commit: 2a8e13b Signed-off-by: Chris Ferry <chris.ferry@shielded.io> Assisted-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Per-ecosystem
labelsadded to.github/dependabot.yml(github-actions →bot:github-actions, everything else →bot:dependencies). Tool-default labels stop accumulating; existing history untouched.Closes #2024