Skip to content

chore(deps): route dependabot/renovate PRs to canonical bot:* labels - #2025

Open
chrisferry wants to merge 5 commits into
mainfrom
chore/canonical-bot-labels
Open

chore(deps): route dependabot/renovate PRs to canonical bot:* labels#2025
chrisferry wants to merge 5 commits into
mainfrom
chore/canonical-bot-labels

Conversation

@chrisferry

Copy link
Copy Markdown
Contributor

Per-ecosystem labels added to .github/dependabot.yml (github-actions → bot:github-actions, everything else → bot:dependencies). Tool-default labels stop accumulating; existing history untouched.

Closes #2024

Dependabot's default labels (dependencies, github_actions, ...) diverge
from the org label standard; label each ecosystem bot:dependencies /
bot:github-actions.

Assisted-by: Claude <noreply@anthropic.com>
@chrisferry chrisferry added the bot:ai-assisted Authored or substantially edited by an AI agent label Aug 14, 2026
@chrisferry
chrisferry requested a review from a team as a code owner August 14, 2026 16:15
@chrisferry chrisferry added the bot:ai-assisted Authored or substantially edited by an AI agent label Aug 14, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2a8e13bc02

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/dependabot.yml

- package-ecosystem: "cargo"
labels:
- "bot:dependencies"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve the changes-check exemption for dependency PRs

For Cargo, npm, and Docker updates, this custom label replaces Dependabot's default dependencies label with only bot:dependencies, but .github/workflows/changes_check.yml lines 85 and 98 still exempt only the exact dependencies and renovate labels. Consequently, bot PRs that touch non-ignored files such as Cargo.lock and lack a change file will run the link check and exit with status 1; update the workflow's exemptions as part of this label migration.

Useful? React with 👍 / 👎.

justinfrevert
justinfrevert previously approved these changes Aug 20, 2026
justinfrevert and others added 2 commits August 20, 2026 13:59
changes_check matches labels with contains() over a fromJSON array, which is an
exact element match, so 'dependencies' does not match 'bot:dependencies'.
Routing Dependabot to the canonical labels would therefore have dropped the
exemption and failed the link check on bot PRs touching non-ignored files.

The legacy names stay listed for now: both label sets currently exist on the
repo, so in-flight bot PRs still carry the old ones.

Assisted-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Chris Ferry <chris.ferry@shielded.io>
@chrisferry

Copy link
Copy Markdown
Contributor Author

Codex P1 applied — the finding was correct and would have broken CI on every bot PR.

Verified the mechanism before fixing: changes_check.yml tests labels with contains(fromJSON(steps.pr.outputs.labels), ...). Because fromJSON yields an array, contains is an exact element match, not a substring one — so bot:dependencies genuinely does not satisfy a 'dependencies' exemption. Routing Dependabot to the canonical labels while leaving the exemptions untouched would have dropped the exemption on lines 85 and 98, and any bot PR touching a non-ignored file (Cargo.lock being the obvious one) would have failed the changes link check with status 1.

Both if: expressions now also exempt bot:dependencies, bot:renovate, and bot:github-actions — the third one matters because the github-actions ecosystem moves to bot:github-actions here, which Codex did not mention but breaks the same way.

I kept the legacy 'dependencies' / 'renovate' entries rather than replacing them: both label sets currently exist on this repo, so in-flight bot PRs still carry the old names and would start failing the moment this merges. They can be dropped once those PRs are closed out.

actionlint clean. Committed normally, not force-pushed, per AGENTS.md.

Required by the changes check, which wants both a PR link and an issue link.

DCO Remediation Commit for Chris Ferry <chris.ferry@shielded.io>

I, Chris Ferry <chris.ferry@shielded.io>, hereby add my Signed-off-by to this commit: 2a8e13b

Signed-off-by: Chris Ferry <chris.ferry@shielded.io>

Assisted-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:ai-assisted Authored or substantially edited by an AI agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Route dependabot/renovate PR labels to canonical bot:* set

2 participants