recipe(koelectra): add NSMC text classification recipe#1144
Open
kujin66 wants to merge 1 commit into
Open
Conversation
Author
|
Reviewer verdict: APPROVE fallback comment / Lane B model PR is ready for maintainer review. Checked items:
Open process note:
I attempted |
kujin66
marked this pull request as ready for review
July 21, 2026 02:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add recipe support for
daekeun-ml/koelectra-small-v3-nsmc, an ELECTRA sequence-classification checkpoint for Korean NSMC sentiment classification. This is a recipe-only L0 contribution with Goal L1 evidence on CPU for fp16 and w8a16. Baseline auto-config already builds the model, so the measurable delta is the checked-in catalog recipe plus verified w8a16 static QDQ quantization path.examples/recipes/daekeun-ml_koelectra-small-v3-nsmc/text-classification_fp16_config.jsonexamples/recipes/daekeun-ml_koelectra-small-v3-nsmc/text-classification_w8a16_config.json| daekeun-ml/koelectra-small-v3-nsmc | text-classification |toexamples/recipes/README.md.temp/koelectra_baseline_buildtemp/koelectra_fp16_buildtemp/koelectra_w8a16_quant_build2.\.venv\Scripts\python.exe -m winml.modelkit build -m daekeun-ml/koelectra-small-v3-nsmc -o temp/koelectra_baseline_build --ep cpu --device cpu --no-analyze --no-optimize --no-quant --no-compile --rebuildBuild complete in 47.0s, final artifacttemp\koelectra_baseline_build\model.onnx.127.0.0.1:9.winml --version:winml, version 0.2.0.origin/main=e0751f6dedfb45e2a1a177a7fff74a111b880514; review checkgit rev-list --count e0751f6dedfb45e2a1a177a7fff74a111b880514..origin/main=0.23b8522077fe9f4cc541b286421c30ad3c186349..\.venv\Scripts\python.exe -m winml.modelkit build -c examples/recipes/daekeun-ml_koelectra-small-v3-nsmc/text-classification_fp16_config.json -m daekeun-ml/koelectra-small-v3-nsmc -o temp/koelectra_fp16_build --ep cpu --device cpu --no-analyze --no-optimize --no-quant --no-compile --rebuildBuild complete in 55.5s, final artifacttemp\koelectra_fp16_build\model.onnx..\.venv\Scripts\python.exe -m winml.modelkit build -c examples/recipes/daekeun-ml_koelectra-small-v3-nsmc/text-classification_w8a16_config.json -m daekeun-ml/koelectra-small-v3-nsmc -o temp/koelectra_w8a16_quant_build2 --precision w8a16 --ep cpu --device cpu --no-analyze --no-optimize --no-compile --rebuildtemp\koelectra_w8a16_quant_build2\model.onnx.QuantizeLinear=426,DequantizeLinear=634, inputsinput_ids/attention_mask/token_type_ids [1,512], outputlogits [1,2].model_knowledge/electra.jsonwith findingelectra-001.{ "vendor": [], "after_winml": ["feature-extraction", "fill-mask", "multiple-choice", "question-answering", "text-classification", "token-classification"], "added_by_winml": ["feature-extraction", "fill-mask", "multiple-choice", "question-answering", "text-classification", "token-classification"], "verdict": "WINML-ONLY" }Model config probe:
{ "model_type": "electra", "architectures": ["ElectraForSequenceClassification"], "vocab_size": 35000, "max_position_embeddings": 512, "type_vocab_size": 2 }{ "model_id": "daekeun-ml/koelectra-small-v3-nsmc", "model_type": "electra", "effort": "L0", "goal_ceiling": "L1", "outcome": "L0", "target_eps": ["cpu"], "catalog_gate": { "baseline_build": "PASS", "verdict": "catalog-needs-numbers", "file_pr": true } }{ "deliverable_ref": "daekeun-ml/koelectra-small-v3-nsmc", "ladder": [ { "tier": "L0", "verdict": "PASS", "evidence": "Baseline auto-config and recipe builds produced loadable ONNX artifacts. fp16 model.onnx: IR=8, opset=17, inputs input_ids/attention_mask/token_type_ids [1,512], output logits [1,2]. w8a16 model.onnx: inputs input_ids/attention_mask/token_type_ids [1,512], output logits [1,2], QuantizeLinear=426, DequantizeLinear=634." }, { "tier": "L1", "verdict": "PASS", "evidence": "CPU providers snapshot: ['DmlExecutionProvider', 'CPUExecutionProvider']. fp16 CPU perf mean 53.371 ms, throughput 18.74 samples/sec, RSS total delta 95.37 MB. w8a16 CPU perf mean 128.133 ms, throughput 7.8 samples/sec, RSS total delta 88.58 MB." } ], "ceiling_reached": "L1", "ceiling_downgraded": false, "new_verdict_shapes": [] }--device cpu --ep cpubuild can resolve savedquanttonull, so quantized recipes need artifact-level QDQ validation.model_knowledge/electra.jsonfindingelectra-001.skill_meta/findings.jsonfinding_meta-057, with paired edit inagents/reviewer.mdrequiring QDQ node / saved quant-config validation for_w8a16_and_w8a8_recipes.winml-climodel PR, preserving the model PR's recipe-only diff scope.Additional notes
origin/maine0751f6dedfb45e2a1a177a7fff74a111b880514before commit23b8522077fe9f4cc541b286421c30ad3c186349.