Add IObservableMap implementation to windows-collections#4325
Open
Add IObservableMap implementation to windows-collections#4325
Conversation
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/6a2e7967-cf50-47aa-84dc-b3740a37c29a Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
kennykerr
April 29, 2026 01:54
View session
…ollections.txt; run cargo fmt Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/c5baf3d4-1e24-4080-9691-8082f9f158ff Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
…o fmt Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/c5baf3d4-1e24-4080-9691-8082f9f158ff Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Collaborator
|
@copilot fix tests |
…vents where Key() returns error Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/fb5ff192-a810-4bd9-a076-7fc60d9ade6f Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Contributor
Author
Fixed in adb3e7c. The |
…st (types now only in windows_collections) Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/34e526cd-a0a8-49f7-9c76-9503d3d2989d Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
…re Event<T> instead of custom handler storage; fix Key() returning E_BOUNDS for Reset events Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/41da4db4-3dea-444e-b8b7-d5f06f1fae66 Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StockObservableMapwithEvent<MapChangedEventHandler<K,V>>from windows-coreStockObservableVectorwithEvent<VectorChangedEventHandler<T>>from windows-coreStockMapChangedEventArgs::Key()to returnErr(Error::from(E_BOUNDS))for Reset events (notError::empty()which has HRESULT 0 = S_OK, causing COM to returnOk(0)and breaking themap_changed_eventtest assertion)fire_changed+fire_changed_resetinto a single method takingOption<K::Default>