Skip to content

windows-rdl arch-specific types#4311

Merged
kennykerr merged 5 commits intomasterfrom
copilot/explore-solutions-to-issue-4299
Apr 28, 2026
Merged

windows-rdl arch-specific types#4311
kennykerr merged 5 commits intomasterfrom
copilot/explore-solutions-to-issue-4299

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 27, 2026 •
edited by kennykerr
Loading

  • Part 1: target() method on Clang builder
  • Part 2: #[arch(...)] shorthand attribute (reader/writer)
  • Part 3: Arch-aware merge in windows-metadata
  • cargo fmt
  • Merge latest master (#4316 moved roundtrip tests to test_roundtrip_rdl)
    • Merged origin/master — no conflicts
    • crates/tests/roundtrip/rdl/src/arches.rdl has #[arch(...)] syntax
    • Old test_rdl roundtrip files removed (superseded by master's reorganization)
    • All 61 test_roundtrip_rdl tests pass including roundtrip_arches
    • test_rdl error/nested-arches tests pass
    • test_metadata merge tests pass

Fixes #4299

Copilot AI and others added 2 commits April 27, 2026 00:18
Copilot AI requested a review from kennykerr April 27, 2026 00:20
@kennykerr
Copy link
Copy Markdown
Collaborator

kennykerr commented Apr 27, 2026

@copilot fmt

@kennykerr
style: cargo fmt
d72d4e3 
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/fc6fe9bc-1c8b-4b7e-82c6-fef7cfb4f5fa

Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 27, 2026

@copilot fmt

Done — formatted in d72d4e3.

Merge remote-tracking branch 'origin/master' into copilot/explore-sol…
e5e1c24 
…utions-to-issue-4299

Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
@kennykerr kennykerr marked this pull request as ready for review April 28, 2026 13:48
@kennykerr kennykerr changed the title feat: implement arch-specific types support (issue #4299) windows-rdl arch-specific types Apr 28, 2026
@kennykerr kennykerr merged commit 5a1e18c into master Apr 28, 2026
28 checks passed
@kennykerr kennykerr deleted the copilot/explore-solutions-to-issue-4299 branch April 28, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennykerr kennykerr Awaiting requested review from kennykerr

Assignees

@kennykerr kennykerr

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

windows-rdl gaps - arch-specific types

2 participants

@kennykerr