Retire completed non-PTY shell output resources#327233
Merged
Merged
Conversation
anthonykim1
marked this pull request as ready for review
July 24, 2026 02:25
anthonykim1
enabled auto-merge (squash)
July 24, 2026 02:26
Contributor
There was a problem hiding this comment.
Pull request overview
Retires completed non-PTY shell output resources once authoritative static results are available, preventing per-session resource growth.
Changes:
- Adds idempotent host-side retirement after publishing completion.
- Avoids attaching completed static results to retired resources.
- Expands lifecycle and compatibility coverage.
Show a summary per file
| File | Description |
|---|---|
agentHostChatContribution.test.ts |
Tests static rendering and attachment cleanup. |
agentHostSessionHandler.ts |
Skips live attachment for authoritative static results. |
copilotAgentSession.test.ts |
Covers retirement and retained-stream scenarios. |
copilotNonPtyShellTerminals.ts |
Implements retirement and tracking cleanup. |
copilotAgentSession.ts |
Retires resources after publishing completion. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Medium
bhavyaus
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #327178
Follow-up to: #327067
ChatToolCallCompleteresult before retiring the live output resource so completed rendering has an authoritative static result.Inspirations from:
AgentHostTerminalManager.disposeTerminal.result.previewthroughgetTerminalOutput.buildTerminalToolSpecificData.