Stream output for SDK built-in shell tool in agent host Copilot#326291
Draft
anthonykim1 wants to merge 2 commits into
Draft
Stream output for SDK built-in shell tool in agent host Copilot#326291anthonykim1 wants to merge 2 commits into
anthonykim1 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Streams Copilot SDK shell output into running Agent Host terminal previews.
Changes:
- Emits partial shell output through
ChatToolCallContentChanged. - Ignores untracked and non-shell partial results.
- Adds coverage for streaming and filtering behavior.
Show a summary per file
| File | Description |
|---|---|
copilotAgentSession.ts |
Forwards partial shell output to active tool calls. |
copilotAgentSession.test.ts |
Tests partial-result handling and filtering. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Medium
| toolCallId: e.data.toolCallId, | ||
| content: [ | ||
| ...tracked.content.filter(content => content.type !== ToolResultContentType.Text), | ||
| { type: ToolResultContentType.Text, text: e.data.partialOutput }, |
anthonykim1
commented
Jul 17, 2026
| turnId: this._turnId, | ||
| toolCallId: e.data.toolCallId, | ||
| content: [ | ||
| ...tracked.content.filter(content => content.type !== ToolResultContentType.Text), |
Contributor
Author
There was a problem hiding this comment.
Would ideally want something like: ToolResultContentType.TerminalOutput or TerminalStreaming, etc. not Text.
Contributor
Author
There was a problem hiding this comment.
Perhaps I should need to revisit ToolResultContentType in ahp. Maybe add a new type like TerminalProgress / CommandProgress , TerminalSnapShot , or evolve the TerminalComplete after changing name.. and then adding status: 'running' | completed, etc
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #324825
Part of: #323399
tool.execution_partial_resultoutput from Copilot SDKbashandpowershellcalls into the running Agent Host tool call.terminal/datapath unchanged, documenting the future move to an output-only AHP terminal when the protocol and SDK expose the required capabilities.Inspirations from:
CopilotSessionWrapper.onToolPartialResult.ChatToolCallContentChangedfollows the existingonDidAssociateTerminalhandler.getTerminalOutput.isShellToolclassification.