Fix script terminal commands returning errors after dispatch - #1737
Merged
Stella Huang (StellaHuang95) merged 1 commit intoAug 26, 2026
Merged
Conversation
|
🔒 Automated review in progress — Heejae Chang (@heejaechang) is auto-reviewing this PR. |
|
Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. |
Heejae Chang (heejaechang)
approved these changes
Aug 25, 2026
Heejae Chang (heejaechang)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Stella Huang (StellaHuang95)
force-pushed
the
copilot/pep723-terminal-return
branch
3 times, most recently
from
August 26, 2026 18:38
8906be5 to
af6bd61
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Stella Huang (StellaHuang95)
force-pushed
the
copilot/pep723-terminal-return
branch
from
August 26, 2026 18:57
af6bd61 to
46e1265
Compare
Stella Huang (StellaHuang95)
merged commit Aug 26, 2026
3d63516
into
microsoft:main
44 checks passed
Stella Huang (StellaHuang95)
deleted the
copilot/pep723-terminal-return
branch
August 26, 2026 19:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The existing normal and dedicated script-terminal command handlers dispatch the script successfully, then fall through to the invalid-context error because the successful branches do not return.
This affects any caller using these existing commands; it is not specific to PEP 723.
Why this change is needed
A script can start running while the command promise rejects, causing callers to report failure after successful dispatch. The false error also makes command completion inconsistent with the underlying terminal operation.
What changed
Behavior and compatibility
Reviewer guide
Validation
npm run compile-tests --silentgit diff --check