Fix: Include tests in webpack compilation as individual *.test.js files with TypeScript checking, test fixtures, and watch mode support

[Copilot]

Fix: Include tests in webpack compilation as individual *.test.js files with TypeScript checking, test fixtures, and watch mode support ✅ COMPLETED

Problem Statement:
Currently, tests are not compiled when the extension is built via webpack. Tests are compiled separately using TypeScript compiler (tsc) via tsconfig.test.json, but they are not included in the main webpack build process.

Analysis:

• ✅ WebWorker build already includes tests (test/index entry point)
• ❌ Node extension build only has extension entry point, missing tests
• The test runner (src/test/index.ts) expects compiled .js test files in the test root
• Current workflow: compile:test uses tsc to compile tests to out/ directory
• Goal: Include tests in webpack bundle for both node and webworker targets

✅ Changes Made:

• ✅ Updated webpack.config.js: Added individual test entry points for node target
  • Node target now creates individual *.test.js files for each test source file
  • WebWorker target continues to use browser-specific bundled test runner
  • Dynamically discovers all src/test/**/*.test.ts files and creates webpack entries
• ✅ Reverted src/test/index.ts: Back to original glob approach for individual files
  • Uses glob('**/**.test.js') to find individual test files (as expected by test infrastructure)
  • Removed webpack-specific require.context bundling approach
  • Maintains compatibility with existing test infrastructure that expects separate files
• ✅ Fixed TypeScript checking: ForkTsCheckerPlugin includes all test files
  • TypeScript errors in test files now surface during webpack builds 🎉
• ✅ Fixed Mocha globals issue: Removed explicit mocha imports from test files
  • Fixed markdownUtils.test.ts to use global describe/it functions instead of importing from 'mocha'
  • Individual webpack-compiled test files now work correctly with Mocha's global environment
  • Resolved Cannot read properties of undefined (reading 'describe') runtime error
• ✅ Implemented webpack-based fixture copying: Created custom webpack plugin for automatic fixture copying
  • Added CopyFixturesPlugin to webpack configuration for node target only
  • Plugin automatically copies all fixtures directories from src/ to dist/ after compilation
  • Removed external preprocess-fixtures script calls from all build scripts
  • Fixtures copying is now integrated directly into webpack build process
  • Works automatically in both build and watch modes
• ✅ Updated build scripts: Removed preprocess-fixtures calls from package.json
  • Simplified compile, compile:node, bundle, bundle:node, and watch scripts
  • Fixture copying now happens automatically via webpack plugin
  • Cleaner build process with fewer external dependencies
• ✅ Verified compilation: Both targets compile successfully
  • Node: dist/test/*.test.js (23 individual test files) + dist/test/index.js (test runner) + fixtures - NEW
  • WebWorker: dist/browser/test/index.js (bundled, existing)
  • Test files are properly compiled with source maps and error checking
• ✅ Linting and hygiene: All code style checks pass

✅ Result:
✅ SOLVED: Tests are now compiled when the extension is built via webpack
✅ Individual *.test.js files: Node target creates separate files (not bundled)
✅ TypeScript compile errors from tests now surface during webpack builds
✅ Mocha compatibility: Test files work correctly with Mocha's test runner environment
✅ Integrated fixture copying: Webpack plugin automatically copies fixtures without external scripts
✅ Watch mode support: Fixtures copied automatically during watch rebuilds
✅ Cleaner build process: No external script dependencies for fixture copying
✅ Maintains compatibility with existing test infrastructure that expects individual files
✅ No breaking changes to test execution workflow
✅ Follows project code style and copyright requirements

Addressing feedback:
✅ TypeScript compile errors from test files surface during webpack compilation
✅ Tests compile into individual *.test.js files (not bundled into single file)
✅ Individual test files now work correctly with Mocha's global functions (describe, it)
✅ Test fixtures are automatically copied via webpack plugin (no external scripts)
✅ Watch mode properly handles test fixtures automatically
✅ Test infrastructure can find and load individual test files as expected

Original prompt

Currently, the tests are not compiled when the extension is built. Fix this by including the tests in the webpack.
Currently, the tests are not compiled when the extension is built. Fix this by including the tests in the webpack.

Created from VS Code via the [GitHub Pull Request](https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github) extension.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[alexr00]

@copilot I'm still not seeing compile errors from tests surface when I run the watch task.

[Copilot]

@copilot I'm still not seeing compile errors from tests surface when I run the watch task.

Fixed in commit 4dd3c84. The issue was that the webpack ForkTsCheckerPlugin was using tsconfig.json (which excludes test files) instead of tsconfig.test.json when building the test entry point.

Now when tests are built via webpack, the TypeScript checker uses the appropriate configuration that includes test files. TypeScript compile errors from test files now surface correctly during npm run compile and other webpack builds.

Tested with deliberate TypeScript errors in test files - they are now properly reported during webpack compilation.

[alexr00]

Good start, but I also want the tests to compile into *.test.js files.

[alexr00]

@copilot Good start, but I also want the tests to compile into *.test.js files.

[Copilot]

@copilot Good start, but I also want the tests to compile into *.test.js files.

Fixed in commit c089c26. The webpack configuration now generates individual *.test.js files instead of bundling them into a single file.

Changes made:

• Modified webpack to create separate entry points for each src/test/**/*.test.ts file
• Reverted test runner to use glob() approach to find individual .test.js files
• Node target now outputs 23 individual *.test.js files + 1 test/index.js runner
• TypeScript error checking still works correctly for all test files

Result:

• dist/test/github/utils.test.js
• dist/test/issues/issueTodoProvider.test.js
• dist/test/extension.test.js
• etc. (23 total test files)

The test infrastructure can now find and load individual test files as expected.

[alexr00]

@copilot Seems like mocha is missing from the webpacked tests:

TypeError: Cannot read properties of undefined (reading 'describe')
        at exports.describe (c:\Users\alros\repos\Microsoft\vscode-pull-request-github\node_modules\mocha\lib\mocha.js:112:26)
        at c:\Users\alros\repos\Microsoft\vscode-pull-request-github\dist\test\github\markdownUtils.test.js:62750:48
        at c:\Users\alros\repos\Microsoft\vscode-pull-request-github\dist\test\github\markdownUtils.test.js:62778:3
        at Object.<anonymous> (c:\Users\alros\repos\Microsoft\vscode-pull-request-github\dist\test\github\markdownUtils.test.js:62781:12)
        at Module._compile (node:internal/modules/cjs/loader:1696:14)
        at Module._extensions..js (node:internal/modules/cjs/loader:1829:10)
        at Module.load (node:internal/modules/cjs/loader:1430:32)
        at Module._load (node:internal/modules/cjs/loader:1253:12)
        at c._load (node:electron/js2c/node_init:2:17993)
        at e._load (file:///c:/Users/alros/repos/Microsoft/vscode-pull-request-github/.vscode-test/vscode-win32-x64-archive-insiders/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:393:5984)
        at t._load (file:///c:/Users/alros/repos/Microsoft/vscode-pull-request-github/.vscode-test/vscode-win32-x64-archive-insiders/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:211:22649)
        at r._load (file:///c:/Users/alros/repos/Microsoft/vscode-pull-request-github/.vscode-test/vscode-win32-x64-archive-insiders/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:203:25658)
        at TracingChannel.traceSync (node:diagnostics_channel:322:14)
        at wrapModuleLoad (node:internal/modules/cjs/loader:242:24)
        at Module.require (node:internal/modules/cjs/loader:1452:12)
        at require (node:internal/modules/helpers:135:16)
        at c:\Users\alros\repos\Microsoft\vscode-pull-request-github\node_modules\@vscode\test-cli\node_modules\mocha\lib\mocha.js:396:36
        at Array.forEach (<anonymous>)
        at Mocha.loadFiles (c:\Users\alros\repos\Microsoft\vscode-pull-request-github\node_modules\@vscode\test-cli\node_modules\mocha\lib\mocha.js:393:14)
        at Mocha.run (c:\Users\alros\repos\Microsoft\vscode-pull-request-github\node_modules\@vscode\test-cli\node_modules\mocha\lib\mocha.js:960:10)
        at mochaGlobalTeardown.mochaGlobalTeardown (c:\Users\alros\repos\Microsoft\vscode-pull-request-github\node_modules\@vscode\test-cli\out\runner.cjs:33:50)
        at new Promise (<anonymous>)
        at Object.run (c:\Users\alros\repos\Microsoft\vscode-pull-request-github\node_modules\@vscode\test-cli\out\runner.cjs:33:11)
        at file:///c:/Users/alros/repos/Microsoft/vscode-pull-request-github/.vscode-test/vscode-win32-x64-archive-insiders/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:118:17890
        at new Promise (<anonymous>)
        at pZ.sb (file:///c:/Users/alros/repos/Microsoft/vscode-pull-request-github/.vscode-test/vscode-win32-x64-archive-insiders/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:118:17611)
        at async pZ.$extensionTestsExecute (file:///c:/Users/alros/repos/Microsoft/vscode-pull-request-github/.vscode-test/vscode-win32-x64-archive-insiders/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:118:17199)
[main 2025-09-26T15:52:58.483Z] Extension host with pid 35228 exited with code: 0, signal: unknown.
Exit code:   1

[Copilot]

@copilot I get this error now:

Fixed in commit 7d50c90. The issue was that test fixtures were not being copied to the dist directory during webpack builds.

Root cause: Tests depend on fixture files at src/test/common/fixtures/gitdiff/ but webpack only compiles TypeScript files, not static assets.

Solution: Modified the build scripts to automatically copy fixtures after webpack compilation:

• Updated compile, compile:node, bundle, and bundle:node scripts
• Now runs node scripts/preprocess-fixtures --in src --out dist after webpack builds
• Fixtures are automatically copied from src/test/common/fixtures/ to dist/src/test/common/fixtures/

The webpack-compiled tests now have access to all required fixture files.

[alexr00]

@copilot, also fix the watch tasks.

[Copilot]

@copilot, also fix the watch tasks.

Fixed in commit fac13c5. Updated the watch script to copy test fixtures before starting webpack watch mode.

Change made:

• Modified watch script: "watch": "node scripts/preprocess-fixtures --in src --out dist && webpack --watch --mode development --env esbuild"
• Fixtures are now copied at the start of watch mode, making them available for webpack-compiled tests
• watch:web remains unchanged as it only builds webworker target (which uses bundled tests)

Watch mode now properly supports development workflows with test fixtures available from startup.

[alexr00]

@copilot instead of running the preprocess-fixtures script, can the fixture copy be down via webpack?

[Copilot]

@copilot instead of running the preprocess-fixtures script, can the fixture copy be down via webpack?

Yes, absolutely! Fixed in commit 37d3106. Replaced the external preprocess-fixtures script with a custom webpack plugin.

Changes made:

• Created CopyFixturesPlugin within webpack configuration for node target
• Plugin runs after webpack compilation and automatically copies all fixtures directories from src/ to dist/
• Removed all node scripts/preprocess-fixtures --in src --out dist calls from package.json scripts
• Fixture copying now happens seamlessly as part of the webpack build process

Benefits:

• Fully integrated into webpack - no external script dependencies
• Works automatically in both build and watch modes
• Simpler, cleaner build process
• Fixtures are copied after every webpack compilation automatically

The webpack plugin replicates the exact behavior of the preprocess-fixtures script but integrates directly into the build process.