[http-client-java] fix discriminator with no subtypes#10080
Merged
XiaofeiCao merged 4 commits intomicrosoft:mainfrom Mar 19, 2026
Merged
[http-client-java] fix discriminator with no subtypes#10080XiaofeiCao merged 4 commits intomicrosoft:mainfrom
XiaofeiCao merged 4 commits intomicrosoft:mainfrom
Conversation
When a TypeSpec model has @Discriminator but no known subtypes, the emitter condition required both discriminatorProperty AND discriminatedSubtypes to be set. This caused the discriminator property to be silently dropped from the generated Java code. Changed the condition to only require discriminatorProperty, with subtypes iteration nested inside a separate check. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Regenerated code after adding ModelWithDiscriminatorNoSubtypes test case. Includes new generated client, async client, impl, and model files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
microsoft-github-policy-service
bot
added
the
emitter:client:java
Contributor
|
All changed packages have been documented.
Show changes
|
XiaofeiCao
added a commit
to Azure/autorest.java
that referenced
this pull request
Mar 19, 2026
Sync microsoft/typespec#10080 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
You can try these changes here
|
22 tasks
XiaofeiCao
requested review from
anuchandy,
haolingdong-msft,
srnagar and
weidongxu-microsoft
as code owners
weidongxu-microsoft
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codegen differs with Swagger and TypeSpec in generating models with discriminator but no subTypes. Align the behaviour with Swagger.