Conversation
When importing an OpenAPI schema with anyOf containing a $ref alongside an inline object, the importer was incorrectly treating it as a model. The fix checks for $ref members before deciding to unwrap to a model. Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix import tool handling of object and enum composition
fix(openapi3): anyOf with $ref + inline object incorrectly imported as model instead of union
Mar 16, 2026
baywet
approved these changes
Mar 16, 2026
baywet
approved these changes
Mar 16, 2026
commit: |
timotheeguerin
approved these changes
Mar 16, 2026
Collaborator
|
You can try these changes here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
anyOfcontains a$refalongside an inline object schema, the importer was discarding the$refvariant and emitting only amodelfrom the object — losing the union semantics entirely.Root cause:
getTypeSpecKindandunwrapSingleAnyOfOneOffiltered out$refmembers when counting "meaningful inline members". With exactly one inline object remaining, they concluded the schema was a plain model, never checking whether$refmembers were also present as union variants.Fix:
hasRefMembersbefore applying the single-inline-object → model shortcut$refmembers exist alongside the inline object, the schema is correctly classified as aunionThe single-inline-object → model unwrap still applies when no
$refmembers are present (e.g.anyOf: [{type: object, ...}, {type: null}]), preserving existing behavior.Original prompt
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.