Introduce validation command and enhance diagnostics#536
Open
jessehouwing wants to merge 4 commits intomicrosoft:masterfrom
Open
Introduce validation command and enhance diagnostics#536jessehouwing wants to merge 4 commits intomicrosoft:masterfrom
jessehouwing wants to merge 4 commits intomicrosoft:masterfrom
Conversation
… warnings/errors.
…zeIssue functions, replace inline formatting with these utilities across multiple files.
Align the invalid task.json server-integration assertion with current CLI diagnostic output and harden async error handling in done-style tests. remove dependency on legacy "Invalid task json" prefix assert on field-level validation errors (id, name, friendlyName) wrap assertion logic in try/catch inside rejection handlers call done(assertionError) on assertion failures to fail fast (not timeout) apply the same catch-block hardening pattern across related build server tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a validation command that includes detailed line, column, and file information for warnings and errors. Extend this functionality to other manifests and refactor diagnostics handling for improved formatting and normalization. Address flaky integration tests related to task.json formatting and enhance error handling for better reliability.
This pull request introduces structured and location-aware validation for extension manifest and task.json files, and adds support for treating warnings as errors. The changes improve error reporting by including file, line, and column information for validation issues, and allow users to opt into stricter validation via a new
warningsAsErrorsoption. Additionally, the handling of JSON/JSONC parsing is enhanced for better diagnostics.Validation and Error Reporting Improvements
warningsAsErrorsflag is set, and are reported with detailed location info. [1] [2] [3]JSON/JSONC Parsing Enhancements
jsonc-parserto support comments and trailing commas (whenjson5is enabled), with parse errors reported with offset-to-line/column conversion. [1] [2] [3] [4]Command-line and API Additions
warningsAsErrorscommand-line argument is introduced and passed through all relevant code paths, allowing users to opt into strict validation. [1] [2] [3] [4] [5] [6] [7]Type and Interface Updates
MergeSettingsinterface now includes the optionalwarningsAsErrorsproperty, and a newExtensionVersionInfointerface is introduced for consistent extension metadata. [1] [2] [3] [4]Miscellaneous
These changes collectively make extension validation more robust, user-friendly, and configurable, especially for teams seeking stricter CI/CD enforcement of manifest correctness.