fix: set MaxRetryDelay to honour Graph API Retry-After up to 315s#119
Open
Jeenil wants to merge 1 commit into
Open
fix: set MaxRetryDelay to honour Graph API Retry-After up to 315s#119Jeenil wants to merge 1 commit into
Jeenil wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #118.
The azure-sdk retry policy correctly reads the
Retry-Afterheader but caps the wait atMaxRetryDelay, which defaults to 60 s. The Graph API Identity Governance endpoint returnsRetry-Aftervalues up to 315 s, causing the SDK to retry too early, re-hit 429, and exhaust retries before the throttle window clears.Setting
MaxRetryDelay: 600 * time.Secondin bothNewRetryOptionsForReadAfterCreateandNewRetryOptionsensures the fullRetry-Afterduration is respected.Changes
internal/clients/options.go: addedMaxRetryDelay: 600 * time.Secondto bothNewRetryOptionsForReadAfterCreateandNewRetryOptions.Note to maintainers
I apologies the original issue title ("Retry-After not honoured") was misleading. The real problem is the missing
MaxRetryDelaycap. I've updated the issue body with the corrected root cause.I'm relatively new to contributing to this provider and happy to revise the approach if the 600 s value or placement isn't right. Please let me know if you'd prefer a different cap, a configurable option, or if this belongs somewhere else in the retry pipeline. Thank you for reviewing