Fix and re-enable RoundTripTest - #20493
Open
RohithPariki wants to merge 3 commits into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This comment has been minimized.
This comment has been minimized.
DHowett
reviewed
Jul 31, 2026
DHowett
left a comment
Member
There was a problem hiding this comment.
cool, did you run the test locally? can you share a screenshot of it passing?
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
DHowett
requested changes
Jul 31, 2026
DHowett
left a comment
Member
There was a problem hiding this comment.
(I was unable to "request changes" as you closed it previously)
This comment has been minimized.
This comment has been minimized.
Author
Member
|
Why is your entire response in quotes? Are you an LLM? |
Author
|
NO , sorry about that , i accidentally formatted the response as a quote. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary of the Pull Request
Fixes and re-enables the
RoundTripTestinInputEngineTest.cppwhich was previously skipped.References and Relevant Issues
Detailed Description of the Pull Request / Additional comments
The test was originally trying to loop over all 256 virtual keys and make sure they roundtrip perfectly through
TerminalInput. That was failing because a lot of keys (like shift, control, OEM keys, etc.) don't actually generate any VT sequences, so the parser just sits there waiting for input and the test eventually fails when checking the queue.To fix this and make the test actually useful again, I just restricted the loop to test keys that we know produce valid VT output (space and alphanumerics).
Validation Steps Performed
Verified the test logic locally to make sure it properly processes the restricted key ranges and drains the expected input queue.
PR Checklist