Open
Conversation
added 8 commits
March 19, 2026 15:25
c42d4d5 to
b34e453
Compare
lilyydu
reviewed
Mar 20, 2026
Collaborator
|
As discussed, let's make sure our deps in examples and docs don't reference anythiing we're deprecating. |
heyitsaamir
reviewed
Mar 24, 2026
Comment on lines
+31
to
+36
| const data = new SubmitActionData({ msteams: new TaskFetchSubmitActionData() }); | ||
| data.opendialogtype = openDialogType; | ||
| const action = new SubmitAction(); | ||
| action.title = title; | ||
| action.data = data; | ||
| return action; |
Collaborator
There was a problem hiding this comment.
sigh, this is just really confusing. (not saying it's your fault -- but just to read this, is really really confusing.). I preferred it with this whole "msteams" stuff was abstracted away.
Right now, this is what I see:
- There is a "SubmitAction"
- Of that submit action, it has a data. This data is a SubmitActionData
- This SubmitActionData has some property called "TaskFetchSubmitActionData" which is on a confusing property called "msteams".
- And it also has a property called "openDialogType".
I preferred it with TaskFetchSubmitActionData was would abstract most of this stuff away.... What do you think? We (I, if you don't want to), can push for a better devex here if there's some validation that this sort of sucks lol. To me it does, because all this msteams crap means nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core.tsfrom latest codegen outputcollab-stage.tsto use new generated types (InvokeSubmitActionData,CollabStageInvokeDataValue,ITabInfo)IMBackAction,InvokeAction,MessageBackAction,SignInAction, andTaskFetchActionas@deprecated, pointing to their generated replacementscommon/tab-info.ts(now generated in core.ts)msteamsadded to several types:AdaptiveCard,SubmitAction,Image,SubmitActionDataISubmitAction.data: anychange tostring | ISubmitActionDataIAdaptiveCard.isVisible: removed fromIAdaptiveCardIHostCapabilities: now extendsRecord<string, string>