Skip to content

Update Adaptive Cards package#476

Open
corinagum wants to merge 10 commits intomainfrom
cg/ac-gen-versionfix
Open

Update Adaptive Cards package#476
corinagum wants to merge 10 commits intomainfrom
cg/ac-gen-versionfix

Conversation

@corinagum
Copy link
Collaborator

@corinagum corinagum commented Mar 18, 2026

  • Fixes [Bug]: Adaptive cards not showing contents in iOS Teams app #426 - default version 1.5 will be applied to payload
  • Updated generated Adaptive Cards core file core.ts from latest codegen output
  • Updated collab-stage.ts to use new generated types (InvokeSubmitActionData, CollabStageInvokeDataValue, ITabInfo)
  • Marked IMBackAction, InvokeAction, MessageBackAction, SignInAction, and TaskFetchAction as @deprecated, pointing to their generated replacements
  • Removed common/tab-info.ts (now generated in core.ts)
  • Other default values added: isEnabled, action mode defaults to "primary", action style "default, requires defaults to new HostCapabilities.
  • msteams added to several types: AdaptiveCard, SubmitAction, Image, SubmitActionData
  • ISubmitAction.data: any change to string | ISubmitActionData
  • IAdaptiveCard.isVisible: removed from IAdaptiveCard
  • IHostCapabilities: now extends Record<string, string>

@corinagum corinagum force-pushed the cg/ac-gen-versionfix branch from c42d4d5 to b34e453 Compare March 19, 2026 22:25
@heyitsaamir
Copy link
Collaborator

As discussed, let's make sure our deps in examples and docs don't reference anythiing we're deprecating.

Comment on lines +31 to +36
const data = new SubmitActionData({ msteams: new TaskFetchSubmitActionData() });
data.opendialogtype = openDialogType;
const action = new SubmitAction();
action.title = title;
action.data = data;
return action;
Copy link
Collaborator

@heyitsaamir heyitsaamir Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh, this is just really confusing. (not saying it's your fault -- but just to read this, is really really confusing.). I preferred it with this whole "msteams" stuff was abstracted away.
Right now, this is what I see:

  1. There is a "SubmitAction"
  2. Of that submit action, it has a data. This data is a SubmitActionData
  3. This SubmitActionData has some property called "TaskFetchSubmitActionData" which is on a confusing property called "msteams".
  4. And it also has a property called "openDialogType".

I preferred it with TaskFetchSubmitActionData was would abstract most of this stuff away.... What do you think? We (I, if you don't want to), can push for a better devex here if there's some validation that this sort of sucks lol. To me it does, because all this msteams crap means nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Adaptive cards not showing contents in iOS Teams app

3 participants