Skip to content

Add upper bound validation for AI response length #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DimaBir merged 5 commits into from
Feb 11, 2026
Merged

Add upper bound validation for AI response length #146

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3025915
Initial plan
Copilot Feb 11, 2026
a3ed64b
Add upper bound validation for AI response length
Copilot Feb 11, 2026
916cf02
Refactor response length validation to use named constants
Copilot Feb 11, 2026
c07bf6c
Optimize response validation and improve comment clarity
Copilot Feb 11, 2026
356b939
Improve consistency in validation messages and comment clarity
Copilot Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions .github/workflows/issue-assistant.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,10 @@ jobs:
with:
script: |
const fs = require('fs');

// Response validation constants
const MIN_AI_RESPONSE_LENGTH = 20;
const MAX_AI_RESPONSE_LENGTH = 1000; // ~150 words (~750 chars) + 250 char buffer for markdown

let wikiContext = '';
if (process.env.HAS_WIKI === 'true') {
Expand Down Expand Up @@ -449,8 +453,20 @@ Keep responses concise (50-150 words). No signatures.`;
return;
}

if (!aiResponse || aiResponse.trim().length < 20) {
console.log('::warning::AI response too short');
// Trim response once for validation
const trimmedResponse = aiResponse ? aiResponse.trim() : '';

if (!trimmedResponse || trimmedResponse.length < MIN_AI_RESPONSE_LENGTH) {
console.log(`::warning::AI response too short (${trimmedResponse.length} chars, min ${MIN_AI_RESPONSE_LENGTH})`);
core.setOutput('response', '');
core.setOutput('is_valid', 'false');
core.setOutput('outcome', 'error');
return;
}

// Check maximum length (50-150 words guidance ≈ 1000 chars with formatting)
if (trimmedResponse.length > MAX_AI_RESPONSE_LENGTH) {
console.log(`::warning::AI response too long (${trimmedResponse.length} chars, max ${MAX_AI_RESPONSE_LENGTH})`);
core.setOutput('response', '');
core.setOutput('is_valid', 'false');
core.setOutput('outcome', 'error');
Expand Down