Added a pair of flags to handle agent-assisted key-based authentication in SSH#30
Open
EnSec4Git wants to merge 1 commit intomicrosoft:mainfrom
Open
Added a pair of flags to handle agent-assisted key-based authentication in SSH#30EnSec4Git wants to merge 1 commit intomicrosoft:mainfrom
EnSec4Git wants to merge 1 commit intomicrosoft:mainfrom
Conversation
danielcshn
approved these changes
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to allow usage of SSH agents for improved security (by removing passwords from the equation) in the SSH handshake process. This also mitigates a related issue, namely the blind trust of the router's SSH fingerprint (enabled by this line -
ssh_client.set_missing_host_key_policy(paramiko.AutoAddPolicy())): When using keys, there is very little even an active network attacker can do.There is one additional flag added that I found necessary when working with Mikrotik routers - failure to negotiate a viable handshake algorithm, as described here: https://forum.mikrotik.com/viewtopic.php?t=157598. I can attest to experiencing this issue firsthand, hence the added flag.
This PR can also provide partial support for the larger feature of SSH key authentication support, as reported here - #25