fix(helm): replace retina.io with retina.sh in hubble ClusterRole templates#2100
Merged
fix(helm): replace retina.io with retina.sh in hubble ClusterRole templates#2100
Conversation
Copilot
AI
changed the title
[WIP] Fix Helm-deployed agent crashing on launch due to incorrect ClusterRoles
Fix retina.io → retina.sh in hubble Helm ClusterRole templates
Mar 5, 2026
Retina Code Coverage ReportTotal coverage no changeIncreased diff
|
matmerr
approved these changes
Mar 18, 2026
Replace all occurrences of the old `retina.io` API group with `retina.sh` in the hubble variant's agent and operator ClusterRole templates to match the actual CRD API group defined in groupversion_info.go. Co-authored-by: Quang Nguyen <nguyenquang@microsoft.com> Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>
4dd76dd to
d2336ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hubble Helm ClusterRole templates still reference the old
retina.ioAPI group, while CRDs moved toretina.shin PR #26. This causes the agent and operator to lack permissions for their own custom resources, crashing on launch.Replaces all 8 occurrences of
retina.iowithretina.sh:templates/agent/clusterrole.yaml(5 occurrences):retinaendpoints,metricsconfigurations,retinaendpoints/finalizers,retinaendpoints/statustemplates/operator/clusterrole.yaml(3 occurrences):captures,captures/finalizers,captures/statusThe standard (non-hubble) variant already uses the correct API group.
Related Issue
Hubble-deployed agent crashes because
retina-agentservice account cannot listmetricsconfigurations.retina.shorcaptures.retina.sh— the ClusterRoles grant access to the nonexistentretina.iogroup instead.Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Verified no
retina.ioreferences remain anywhere underdeploy/. Diff is a pure string replacement with no structural changes.Additional Notes
None.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.
Original prompt
This section details on the original issue you should resolve
<issue_title>Helm-deployed agent crashing on launch: Helm-deployed ClusterRoles for operator, agent etc still use retina.io instead of retina.sh</issue_title>
<issue_description>Describe the bug
Service account in
kube-system,retina-agent, seemingly has no permissions to list Retina's own CRs defined as being inretina.shnamespace.EDIT Below,
retina-agent-initis actually running the operator image instead of the init. My bad! The apigroups are, nonetheless, wrong.Here's an excerpt from
retina-agent-initcontainer of theretina-agent-*pod (it never reaches theretina-agentcontainer):This error is similar to #1122, but actually unrelated.
Examining the relevant
ClusterRoleobject,retina-cluster-reader, I can see that in multiple places it seems to referenceretina.iowhich is gone since pull request #26 which replacedretina.iowithretina.shin most places:retina/deploy/hubble/manifests/controller/helm/retina/templates/agent/clusterrole.yaml
Lines 17 to 24 in f525540
retina/deploy/hubble/manifests/controller/helm/retina/templates/agent/clusterrole.yaml
Lines 45 to 82 in f525540
This is also happening in the operator
ClusterRoleobject,retina-operator-role:https://github.com/microsoft/retina/blob/f2da04b8bbe1a3b232c2af2987b2f87051392a34/deploy/hubble/manifests/controller/helm/retina/templat...
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.