Fix CMake 3.31+ compatibility by removing CONFIGURE_DEPENDS from all CMakeLists.txt #2790
+78
−78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake 3.31 introduced breaking changes with
CONFIGURE_DEPENDSinfile(GLOB)commands, causing build failures across CI.Changes
Removed
CONFIGURE_DEPENDSfrom all 72 CMakeLists.txt files in the React Native codebase:Hermes-related files (6):
ReactCommon/react/runtime/hermes/CMakeLists.txtReactCommon/hermes/executor/CMakeLists.txtReactCommon/hermes/inspector-modern/CMakeLists.txtReactAndroid/src/main/jni/react/runtime/hermes/jni/CMakeLists.txtReactAndroid/src/main/jni/react/hermes/reactexecutor/CMakeLists.txtReactAndroid/src/main/jni/react/hermes/instrumentation/CMakeLists.txtAdditional files (66):
Example change:
Impact
CMake will no longer auto-detect added/removed source files. Manual reconfiguration required when modifying file lists. This is the recommended approach for CMake 3.31+ compatibility.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.