test: add global virtualenvs coverage - #423
Merged
Karthik Nadig (karthiknadig) merged 1 commit intoApr 15, 2026
Merged
Conversation
Test Coverage Report (Linux)
Coverage increased! Great work! |
Performance Report (Linux) ✅
Legend
|
Performance Report (macOS)
Legend
|
Test Coverage Report (Windows)
Coverage increased! Great work! |
Performance Report (Windows) ➖
Legend
|
Copilot started reviewing on behalf of
Karthik Nadig (karthiknadig)
April 12, 2026 09:19
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional unit test coverage to the pet-global-virtualenvs utility crate to ensure global virtualenv discovery includes both XDG data locations (pipenv-style) and the default home .virtualenvs location.
Changes:
- Add a unit test verifying that virtualenv children under
$XDG_DATA_HOME/virtualenvsand~/.virtualenvsare both discovered. - Assert deterministic ordering/dedup behavior by comparing directly against the function output (which sorts/dedups internally).
Show a summary per file
| File | Description |
|---|---|
| crates/pet-global-virtualenvs/src/lib.rs | Adds a new unit test covering XDG + default home virtualenv child discovery paths. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
Karthik Nadig (karthiknadig)
marked this pull request as ready for review
April 13, 2026 02:47
Karthik Nadig (karthiknadig)
requested a review
from Eleanor Boyd (eleanorjboyd)
April 13, 2026 02:47
Karthik Nadig (karthiknadig)
enabled auto-merge (squash)
April 13, 2026 02:48
Eleanor Boyd (eleanorjboyd)
approved these changes
Apr 15, 2026
Karthik Nadig (karthiknadig)
deleted the
test/issue-389-global-virtualenvs
branch
April 15, 2026 22:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
.virtualenvschildren inpet-global-virtualenvs.Validation:
Refs #389