Fix field editors force-closing on visibility change in assistive tech browsers #11056
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In assistive tech interfaces like Grid3, users navigate between pages to access different keyboard layouts (e.g., switching from navigation controls to a numeric keypad). These page changes trigger
visibilitychangeevents in the embedded browser, which currently force-close any open field editors, breaking the editing workflow.Root Cause
The
onPageVisibilityChangedhandler runsthis.runSimulator()without thebackground: trueflag when resuming from visibility. This triggerseditor.beforeCompile(), which explicitly closes field editors viaBlockly.DropDownDiv.hide()andBlockly.WidgetDiv.hide().Changes
{ background: true }torunSimulator()in theresumeOnVisibilitypath (line 492 inapp.tsx)autoRunSimulatorDebounced(), which also restarts the simulator without disrupting active editingWhen
background: trueis set,runSimulator()skips thebeforeCompile()call, preserving field editor state during visibility transitions.Impact
Users accessing MakeCode through assistive tech can now switch between interface pages without losing editing context in field editors.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.