Skip to content

fix rendering for getter/setter blocks in eval tool #11054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
riknoll merged 1 commit into from
Jan 20, 2026
Merged

fix rendering for getter/setter blocks in eval tool #11054

riknoll merged 1 commit into from
Jan 20, 2026
+24 −14

Conversation

@riknoll
Copy link
Member

@riknoll riknoll commented Jan 20, 2026

fixes microsoft/pxt-arcade#7175

two separate issues here:

  1. getter/setter blocks were throwing an exception during rendering that stopped the render operation from continuing after a certain point
  2. the height of the sprites category was getting squished because of the max height rule in the CSS

@riknoll riknoll requested a review from a team January 20, 2026 22:01
@riknoll riknoll merged commit e6185c5 into master Jan 20, 2026
20 checks passed
@riknoll riknoll deleted the dev/riknoll/arcade-eval-tool-block-render branch January 20, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwunderl jwunderl jwunderl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Block rendering

3 participants

@riknoll @jwunderl