Remove Ask AI criteria from catalog dialog

[Copilot]

The Criteria dialog exposed "Ask AI" as a selectable criteria option, creating confusion since a dedicated Ask AI button already provides this functionality with a different UX.

Changes

• Added filtering logic in teachertool/src/state/helpers.ts to exclude ai_question criteria from the getCatalogCriteria helper
• Preserved ai_question criteria configuration in common-docs/teachertool/catalog-shared.json (needed for Ask AI overlay's default questions)
• Preserved Ask AI instances in general-code-quality.json example checklist

Impact
Users now access Ask AI exclusively through the dedicated button. The Ask AI criteria configuration remains available for the AskAIOverlay component to provide default question prompts, while being filtered out from the "Add Criteria" dialog display. The AskAIButton, AskAIOverlay, and addAiQuestionCriteriaToChecklist components remain unchanged and functional.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Remove Ask AI option from Criteria dialog window</issue_title>
<issue_description>Now that we have a separate Ask AI button, let's remove the Ask AI option from the Criteria dialog window.
This creates confusion since there are 2 different ways to do the same thing, and the experiences are different.

</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Remove Ask AI option from Criteria dialog window pxt-arcade#7314

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[jwunderl]

@copilot the configuration there is still used for e.g. default questions. Probably best to remove from the teachertool portion itself, we already have the opposite logic to fill ask ai so just filter them out from the add criteria section

[Copilot]

@copilot the configuration there is still used for e.g. default questions. Probably best to remove from the teachertool portion itself, we already have the opposite logic to fill ask ai so just filter...

Updated in commit 30c1218. Restored the catalog configuration and added filtering logic in CatalogOverlay.tsx to exclude ai_question criteria from the display while keeping it available for the Ask AI overlay's default questions.