Skip to content

Comments

Add TS types for Serial object#989

Open
maciejmrozinski wants to merge 2 commits intomicrosoft:masterfrom
maciejmrozinski:add-serial-types
Open

Add TS types for Serial object#989
maciejmrozinski wants to merge 2 commits intomicrosoft:masterfrom
maciejmrozinski:add-serial-types

Conversation

@maciejmrozinski
Copy link
Contributor

@maciejmrozinski maciejmrozinski commented Sep 15, 2020

Replacing custom Serial types with @types package:

  • added @types/dom-serial npm package
  • bumped typescript version (needed for WritableStream DOM definition used in Serial)
  • bumped jquery types version (conflicted with newer typescript)
  • make it works in newest Chrome

@pelikhan pelikhan self-requested a review November 13, 2020 12:55
@pelikhan
Copy link
Member

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants