Skip to content

Bump pxt 12.x and some other changes#1052

Open
THEb0nny wants to merge 92 commits intomicrosoft:masterfrom
THEb0nny:bump-pxt-10
Open

Bump pxt 12.x and some other changes#1052
THEb0nny wants to merge 92 commits intomicrosoft:masterfrom
THEb0nny:bump-pxt-10

Conversation

@THEb0nny
Copy link
Contributor

@THEb0nny THEb0nny commented Mar 19, 2024

After switching to pxt-core v10, fieldmotors break.
Related to this.

I understand that these changes should be considered after this
#1048

microsoft/pxt-microbit#5496
microsoft/pxt#9865

@THEb0nny
Copy link
Contributor Author

Fixed all fields field_motors, field_ports, field_brickbuttons, field_music except field_color. When choosing a color, the color does not change. There is no error in the console.

Replacing ports with images. field ports has been removed. Almost completely repeats the functionality.
@THEb0nny
Copy link
Contributor Author

THEb0nny commented Mar 20, 2024

Replacing field ports to images. field ports has been removed. Almost completely repeats the functionality.

All sensor blocks that used field_ports had to register this. I don’t know how it could have been done differently without repeating these lines.

this.fieldOptions.columns="4"
this.fieldOptions.width="300"

Accidentally added field_colors changes to this commit. He's not ready. There are no errors, but the color selection does not work.

Where did turnRatio come from?
The last change to field_colour removed the addition of className. It’s not clear for what reason, but I’m adding it myself now.
The new version of FieldColorNumber does not apply applyColour() inside the doValueUpdate_() method. Secondly, the applyColour() method was redesigned in the new version so that it no longer worked with this enum code.
@THEb0nny
Copy link
Contributor Author

The colorenum field has been fixed.

@THEb0nny
Copy link
Contributor Author

@jwunderl @riknoll can someone see all the changes?

@THEb0nny
Copy link
Contributor Author

THEb0nny commented Nov 21, 2025

I noticed one thing: the EV3 code stops immediately after loading. I don't understand what's causing this. And I don't understand when this happened. I don't remember if I tested it on hardware right away when creating the PR.

@abchatra @riknoll Is this related to the need to update the runtime due to increased pxt-core versions? core---linux?

@abchatra
Copy link
Collaborator

We haven't done any intentional change and don't have bandwidth either to debug.

Fixed a build warning:
Skipped data-uri embedding of ../docs/static/icons/ts-logo-512.svg because file not found
@THEb0nny
Copy link
Contributor Author

THEb0nny commented Feb 19, 2026

We haven't done any intentional change and don't have bandwidth either to debug.

I figured out what it was and rolled back the change. It was because I wanted to specify which folder to upload the project to on the controller. I understand that the EV3 bootloader automatically uploads to the folder specified in the firmware. But my file compiles and specifies a different path. This creates two files with incorrect references to each other. I hope it was explained clearly.
I think I did this before, and the project folder was created, but as I understand it now, it happens when uploading via webserial over Bluetooth, where the EV3 bootloader isn't involved.
I want to leave this for future changes and implement USB uploading from webserial over HID, like in the Microbit.

@abchatra @riknoll I've fixed a lot of things in this update. Theme support is now adequate, and the editor's appearance is now fine. There are probably still a few remaining issues, but they're not key, and I'd like to revisit them later after the new beta version is released. All further changes will be made in separate PRs.

First you need to approve this pr because this one works on the basis of that
#1048

Please look at this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants