Skip to content

Change legendGroup id to class #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Natalya Smirnova (natalya-smirnova) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change legendGroup id to class #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/legend/svgLegend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ export class SVGLegend implements ILegend {

this.group = this.svg
.append("g")
.attr("id", "legendGroup");
.classed("legendGroup", true);

this.interactiveBehavior = interactiveBehavior ? interactiveBehavior : new LegendBehavior();
this.interactivityService = interactivityService;
Expand Down
2 changes: 1 addition & 1 deletion test/legendTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ describe("legend", () => {
let behavior = new MockOpacityBehavior();
const svg = select(element.querySelector("div#jasmine-fixtures svg"));
const clearCatcher = appendClearCatcher(svg);
const itemsSelection = svg.select("#legendGroup").selectAll(".legendItem");
const itemsSelection = svg.select(".legendGroup").selectAll(".legendItem");

let behaviorOptions: LegendBehaviorOptions = {
legendItems: itemsSelection,
Expand Down