Migrate toolchain to Vitest/TS6 and modernize CI + dependencies - #139
Conversation
Alexey (Demonkratiy)
left a comment
Alexey (Demonkratiy)
left a comment
There was a problem hiding this comment.
Toolchain migration looks solid: CI is green, the lockfile is clean (all resolved URLs on registry.npmjs.org, npm audit clean), and rootDir + the prebuild clean fix the stale lib/src / lib/test output layout.
Blocking: version must be 9.0.0 — details in the comment on package.json.
Worth fixing here (non-blocking): two no-op ESLint overrides, the unused parserOptions.project, the include pattern, and the waitForRender helper.
Not for this PR:
skipLibCheck: trueis unavoidable — it's an upstream bug inpowerbi-visuals-api(legacydeclare modulerejected by TS 6). Filed separately; the flag can be dropped once a fix ships.- Linting
test/— currently excluded; 551 issues, 543 of them auto-fixableprefer-const. .nvmrcfor the dev Node version, now that CI is on 20/22.
…ipLibCheck, fix Vitest include and legend tests
Resolve workflow conflicts by keeping the upgraded actions pinned to full-length SHAs, per microsoft#140.
Default setup has been configured on the repository since 2026-08-24 and covers actions, javascript and typescript. GitHub rejects SARIF from an advanced configuration while default setup is enabled, so codeql-analysis.yml could only ever fail.
Alexey (Demonkratiy)
left a comment
Alexey (Demonkratiy)
left a comment
There was a problem hiding this comment.
All six review comments are addressed. Verified locally on the current head: lint 0 errors / 8 warnings (the expected no-useless-assignment set), build ok, test:typecheck ok, 227 passed / 5 skipped.
I pushed three commits to this branch:
- Merge
main— the PR had goneCONFLICTINGafter #140 landed. Resolved by keeping your upgraded actions but pinning them to full-length SHAs per the new convention, so the merge doesn't revert that hardening:actions/checkout@d23441a4 # v6.1.0andactions/setup-node@24997072 # v6.5.0, across all 4 usages inbuild.ymlandrelease.yml. - CHANGELOG — moved
colorutilsandtestutilsout of Breaking changes; both aredevDependencies(andcolorutilsisn't imported fromsrc/at all), so they never reach a consumer's dependency tree. - Removed
codeql-analysis.yml— CodeQL default setup has been configured on the repo since 2026-08-24, and GitHub rejects SARIF from an advanced configuration while it's enabled (CodeQL analyses from advanced configurations cannot be processed when the default setup is enabled). That workflow could only ever fail; default setup covers more languages anyway.
Re: the upstream powerbi-visuals-api issue you offered to file — already tracked internally, nothing needed on your side.
Remaining follow-ups, none blocking: the 8 no-useless-assignment warnings, linting test/, and an .nvmrc for the dev Node version.
3 participants
No description provided.