fix(docs): add globalTimeout note to CI documentation - #42535
Closed
Wu Shuwen (dajiaohuang) wants to merge 1 commit into
Closed
fix(docs): add globalTimeout note to CI documentation#42535Wu Shuwen (dajiaohuang) wants to merge 1 commit into
Wu Shuwen (dajiaohuang) wants to merge 1 commit into
Conversation
Fixes microsoft#42533 Add a note explaining the relationship between GitHub Actions timeout-minutes and Playwright's globalTimeout config option.
|
This matches the actual failure mode exactly, including the wording. Confirming from having hit this for real: a job with The note reads correctly to me. Thanks for picking this up and writing the fix. |
Collaborator
|
Closing in favor of #42563. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #42533
Add a note to the CI documentation explaining the relationship between GitHub Actions'
timeout-minutesand Playwright'sglobalTimeoutconfiguration option.Problem
The recommended GitHub Actions workflow sets a job-level
timeout-minutesbut doesn't mentionglobalTimeout. When a test suite exceeds the job timeout:cancelledrather thanfailure!cancelled()guardSolution
Add a note explaining that setting
globalTimeoutbelow the job'stimeout-minuteslets Playwright stop itself first, producing a proper failure with a full report instead of a cancelled run.