Skip to content

test: tolerate test location column changes #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into from
Oct 8, 2026
Merged

test: tolerate test location column changes #820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/global-errors.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ test('should report duplicate test title', async ({ activate }) => {
await expect.poll(() => vscode.languages.getDiagnostics()).toEqual([
{
message: 'Error: duplicate test title \"one\", first declared in test.spec.ts:3',
range: { start: { line: 4, character: 10 }, end: { line: 5, character: 0 } },
range: { start: { line: 4, character: expect.any(Number) }, end: { line: 5, character: 0 } },
severity: 'Error',
source: 'playwright',
}
Expand Down
12 changes: 6 additions & 6 deletions tests/run-tests.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1056,7 +1056,7 @@ test('should produce output twice', async ({ activate }) => {
expect(testItems.length).toBe(1);

const testRun1 = await testController.run(testItems);
expect(testRun1.renderLog({ output: true })).toBe(`
expect(testRun1.renderLog({ output: true }).replace(/:3:\d+ ›/g, ':3 ›')).toBe(`
tests > test.spec.ts > one [2:0]
enqueued
started
Expand All @@ -1066,16 +1066,16 @@ test('should produce output twice', async ({ activate }) => {

Running 1 test using 1 worker

[1/1] tests${path.sep}test.spec.ts:3:11 › one
tests${path.sep}test.spec.ts:3:11 › one
[1/1] tests${path.sep}test.spec.ts:3 › one
tests${path.sep}test.spec.ts:3 › one
some output

1 passed (XXms)

`);

const testRun2 = await testController.run(testItems);
expect(testRun2.renderLog({ output: true })).toBe(`
expect(testRun2.renderLog({ output: true }).replace(/:3:\d+ ›/g, ':3 ›')).toBe(`
tests > test.spec.ts > one [2:0]
enqueued
enqueued
Expand All @@ -1085,8 +1085,8 @@ test('should produce output twice', async ({ activate }) => {

Running 1 test using 1 worker

[1/1] tests${path.sep}test.spec.ts:3:11 › one
tests${path.sep}test.spec.ts:3:11 › one
[1/1] tests${path.sep}test.spec.ts:3 › one
tests${path.sep}test.spec.ts:3 › one
some output

1 passed (XXms)
Expand Down
Loading