Repository navigation
chore: build the driver and the generated files from a pinned microsoft/playwright commit - #3285
Merged
Pavel Feldman (pavelfeldman) merged 1 commit intoOct 22, 2026
Conversation
Pavel Feldman (pavelfeldman)
force-pushed
the
roll_auto
branch
from
October 21, 2026 23:38
2e4f0f5 to
820ef0d
Compare
Pavel Feldman (pavelfeldman)
marked this pull request as ready for review
October 21, 2026 23:38
Pavel Feldman (pavelfeldman)
force-pushed
the
roll_auto
branch
2 times, most recently
from
October 22, 2026 04:31
79c07aa to
18eb47c
Compare
…ft/playwright commit DRIVER_VERSION holds a microsoft/playwright commit. scripts/upstream.py clones microsoft/playwright into .upstream/ (gitignored) at that commit; the wheel build builds the driver from it, and scripts/update_api.sh generates the API, the protocol files and the test registry from it. Nothing is downloaded from npm. - CI, publish, the Docker test and the Azure Docker pipeline run the same steps: get Playwright, build, test. The Lint job also checks that the generated files are up to date. - CONTRIBUTING.md, ROLLING.md and the playwright-roll skill follow these steps. `python scripts/upstream.py changes` lists the upstream diff to port, with the Python file for each change. - The wheel build starts from an empty build/, so that a deleted module does not go into the wheel. - ChannelOwner types its channel as Channel: mypy reports a subclass that does not declare its channel type, as Root did not. - The Docker test runs the suites as CI does: the dot reporter, two workers, and the async suite also after a failed sync suite. - Remove scripts/example_sync.py and scripts/example_async.py, left over from the conda recipe.
Pavel Feldman (pavelfeldman)
force-pushed
the
roll_auto
branch
from
October 22, 2026 14:53
18eb47c to
1bff03d
Compare
Dmitry Gozman (dgozman)
approved these changes
Oct 22, 2026
Pavel Feldman (pavelfeldman)
merged commit Oct 22, 2026
4077a29
into
microsoft:main
25 of 35 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DRIVER_VERSIONis a microsoft/playwright commit.python scripts/upstream.py checkoutclones it into.upstream/(gitignored); the wheel build builds the driver from it, and./scripts/update_api.shgenerates the API from it. Nothing is downloaded from npm.CONTRIBUTING.md,ROLLING.mdand the roll skill follow these steps;python scripts/upstream.py changeslists the upstream diff to port.