Repository navigation
fix(network): keep blank values in Request.post_data_json for form bodies - #3248
Merged
Yury Semikhatsky (yury-s) merged 1 commit intoOct 13, 2026
Conversation
…dies parse_qsl drops empty fields by default, so a body such as a=&b=1 lost the a key. The JS client uses URLSearchParams, which keeps them.
Pavel Feldman (pavelfeldman)
approved these changes
Oct 13, 2026
Yury Semikhatsky (yury-s)
merged commit Oct 13, 2026
5313ac2
into
microsoft:main
28 of 29 checks passed
Mohammed Alkindi (MohammedAlkindi)
deleted the
fix/network-keep-blank-values-in-post-data-json
branch
October 15, 2026 15:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request.post_data_jsonparsed form bodies withparse_qsl, which drops blank values, soa=&b=1came back as{'b': '1'}. It now passeskeep_blank_values=True, matching the JS client'sURLSearchParams.Fixes microsoft/playwright#43330