fix(extension): notify connect page when pending connection is closed#1556
Merged
yury-s merged 1 commit intomicrosoft:mainfrom Apr 17, 2026
Merged
fix(extension): notify connect page when pending connection is closed#1556yury-s merged 1 commit intomicrosoft:mainfrom
yury-s merged 1 commit intomicrosoft:mainfrom
Conversation
Replace the tab-inactivity timeout with a simpler approach: when the relay WebSocket closes while the connect page is still showing the tab picker, send a `pendingConnectionClosed` message and remove the tab from the Playwright group. Also guard `Target.createTarget` in the extension's `forwardCDPCommand` handler for old CLI clients.
pavelfeldman
approved these changes
Apr 17, 2026
PM-Labs
pushed a commit
to PM-Labs/mcp-playwright
that referenced
this pull request
Apr 19, 2026
…microsoft#1556) Replace the tab-inactivity timeout with a simpler approach: when the relay WebSocket closes while the connect page is still showing the tab picker, send a `pendingConnectionClosed` message and remove the tab from the Playwright group. Also guard `Target.createTarget` in the extension's `forwardCDPCommand` handler for old CLI clients.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the tab-inactivity timeout with a simpler approach: when the relay WebSocket closes while the connect page is still showing the tab picker, send a
pendingConnectionClosedmessage and remove the tab from the Playwright group. Also guardTarget.createTargetin the extension'sforwardCDPCommandhandler for old CLI clients.