xflowey: fix --custom-openvmm-hcl command#3147
Open
mingweishih wants to merge 3 commits intomicrosoft:mainfrom
Open
xflowey: fix --custom-openvmm-hcl command#3147mingweishih wants to merge 3 commits intomicrosoft:mainfrom
mingweishih wants to merge 3 commits intomicrosoft:mainfrom
Conversation
Signed-off-by: Ming-Wei Shih <mishih@microsoft.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes cargo xflowey ... --custom-openvmm-hcl so that supplying a custom openvmm_hcl binary actually bypasses the build step (matching the behavior of --custom-openhcl-boot / --custom-sidecar) when generating an OpenHCL IGVM from a recipe.
Changes:
- Use the provided
custom_openvmm_hclpath to construct theOpenvmmHclOutputinstead of always buildingopenvmm_hcl. - Adjust the “fake dbg” filename used for custom
openhcl_bootoutputs.
This reverts commit 4b4257c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that the
--custom-openvmm-hclxflowey command does not use the provided custom hcl as--custom-openhcl-bootand--custom-sidecardo.