Conversation
There was a problem hiding this comment.
Pull request overview
Updates Flowey’s CI runner pool configuration to point both GitHub Actions and Azure DevOps pipelines at new 1ES pool names / image overrides, and regenerates the derived pipeline YAMLs accordingly.
Changes:
- Switch GitHub self-hosted runner labels to the new
openvmm-gh-*pools and new1ES.ImageOverridevalues. - Update ADO pool selection to include explicit runner demands (image override) alongside the pool name, with a small helper extension trait for ergonomics.
- Regenerate CI YAML outputs (
ci-flowey/and.github/workflows/) to reflect the new pool configuration.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| flowey/flowey_hvlite/src/pipelines_shared/gh_pools.rs | Updates GitHub self-hosted pool + image override labels. |
| flowey/flowey_hvlite/src/pipelines_shared/ado_pools.rs | Introduces new ADO pool constants, adds image-demands, and an extension trait for setting pool config. |
| flowey/flowey_hvlite/src/pipelines/checkin_gates.rs | Switches jobs to use the new ADO pool config helper. |
| ci-flowey/openvmm-pr.yaml | Regenerated ADO pipeline YAML to use new pool + demands format. |
| .github/workflows/openvmm-pr.yaml | Regenerated GitHub PR workflow to use new runner labels. |
| .github/workflows/openvmm-pr-release.yaml | Regenerated GitHub PR-release workflow to use new runner labels. |
| .github/workflows/openvmm-ci.yaml | Regenerated GitHub CI workflow to use new runner labels. |
babayet2
added
the
release-ci-required
| } | ||
|
|
||
| /// Extension trait to configure an ADO pool from an [`AdoRunner`]. | ||
| pub trait AdoPoolExt { |
There was a problem hiding this comment.
nit: This trait feels unnecessary, we should just have default_x86_pool return an AdoPool and change ado_set_pool to accept it instead of just a string. This would make it consistent with the GitHub semantics.
| /// jobs that require more than the default disk space (e.g. to ensure vmm_tests | ||
| /// have enough space to download test VHDs) | ||
| pub fn windows_intel_self_hosted_largedisk() -> GhRunner { | ||
| pub fn windows_intel_self_hosted() -> GhRunner { |
There was a problem hiding this comment.
nit: I think we should rename these to ...1es_hosted... rather than ...self_hosted... to distinguish between the actual self-hosted runners with hardware we maintain and these 1es runners.
This PR makes two changes