hvsock: Accept lowercase handshake prefix#3142
Open
sprt wants to merge 2 commits intomicrosoft:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the hybrid vsock (hvsock) handshake parsing in the VMBus server to accept a lowercase connect request line, aligning OpenVMM with other VMM/runtime implementations that send/accept that variant.
Changes:
- Accept
connect(lowercase) in addition toCONNECTwhen parsing hybrid vsock connect requests.
sprt
changed the title
OpenVMM expects "CONNECT " but Cloud Hypervisor also accepts "connect " [1], and Kata sends "connect " [2] as well, so align with them. [1] https://github.com/cloud-hypervisor/cloud-hypervisor/blob/57e766bdbbfcdf1f36f696fc735fbebbea97f5ca/virtio-devices/src/vsock/unix/muxer.rs#L493-L506 [2] https://github.com/kata-containers/kata-containers/blob/8c2b7ed619badeb9c0e0cf24e23f6b09bc109fcf/src/runtime-rs/crates/agent/src/sock/hybrid_vsock.rs#L73 Signed-off-by: Aurélien Bombo <abombo@microsoft.com>
sprt
force-pushed
the
fix-hvsock-connect-prefix
branch
from
7ad99ed to
b7d6c83
Compare
chris-oo
approved these changes
Mar 27, 2026
Member
chris-oo
left a comment
chris-oo
left a comment
There was a problem hiding this comment.
LGTM. Not sure if you need to rebase on latest main to pickup the mitigation for github actions not running correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenVMM only accepts
CONNECTbut Cloud Hypervisor also acceptsconnect[1], and Kata sendsconnect[2] as well, so align with them.[1] https://github.com/cloud-hypervisor/cloud-hypervisor/blob/57e766bdbbfcdf1f36f696fc735fbebbea97f5ca/virtio-devices/src/vsock/unix/muxer.rs#L493-L506
[2] https://github.com/kata-containers/kata-containers/blob/8c2b7ed619badeb9c0e0cf24e23f6b09bc109fcf/src/runtime-rs/crates/agent/src/sock/hybrid_vsock.rs#L73