fix(ci): 'rc' qualifier ignored when packaging onnxruntime-node#28350
Open
sanaa-hamel-microsoft wants to merge 1 commit intomainfrom
Open
fix(ci): 'rc' qualifier ignored when packaging onnxruntime-node#28350sanaa-hamel-microsoft wants to merge 1 commit intomainfrom
onnxruntime-node#28350sanaa-hamel-microsoft wants to merge 1 commit intomainfrom
Conversation
sanaa-hamel-microsoft
force-pushed
the
dev/sanaahamel/ci-fix-ort-node-pkging-rc
branch
from
754699c to
4890ad0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
onnxruntime-nodeandonnxruntime-commonNPM packages lacking an RC suffix when built in Release + RC mode.This isn't great, the suffix looks like
-QUAL.DATE-COMMIT. This'll break the publishing pipeline if the packaging pipelines (zip-nuget and NPM) span more than a single day due to same-version checks/enforcement.Motivation and Context
Missing the RC qualifier/suffix fails the NPM publish pipeline. It correctly assets that the (onnxruntime-node, onnxruntime-common, and onnxruntime-web) do not share a common version specifier.