Fix wrong config name used for custom binding username claim#3096
Open
weilai-irl wants to merge 1 commit intoMOODLE_500_STABLEfrom
Open
Fix wrong config name used for custom binding username claim#3096weilai-irl wants to merge 1 commit intoMOODLE_500_STABLEfrom
weilai-irl wants to merge 1 commit intoMOODLE_500_STABLEfrom
Conversation
…and idp connection
There was a problem hiding this comment.
Pull request overview
Fixes a configuration lookup bug in the auth_oidc login flow where the custom “binding username claim” name was being read from the wrong config key, preventing custom-claim bindings from working.
Changes:
- Update the config key used when
bindingusernameclaimis set tocustomto readcustomclaimname.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.