Prevent closure serialisation error in debug backtrace#3073
Open
weilai-irl wants to merge 1 commit intoMOODLE_500_STABLEfrom
Open
Prevent closure serialisation error in debug backtrace#3073weilai-irl wants to merge 1 commit intoMOODLE_500_STABLEfrom
weilai-irl wants to merge 1 commit intoMOODLE_500_STABLEfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a potential serialization error in the debug logging functionality by preventing closures (anonymous functions) in function arguments from being captured in debug backtraces. The change applies the DEBUG_BACKTRACE_IGNORE_ARGS flag to debug_backtrace() calls to exclude function arguments, which could contain non-serializable closures that would cause errors when the event data is stored.
Changes:
- Modified
debug_backtrace()call inlocal/o365/classes/utils.phpto useDEBUG_BACKTRACE_IGNORE_ARGSflag
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.