Skip to content

doc: add regular-file shares to the responsibility map - #489

Merged
Pedro Henrique Penna (ppenna) merged 1 commit into
devfrom
doc-sync/ownership-map-file-shares
Oct 11, 2026
Merged

Pedro Henrique Penna (ppenna) merged 1 commit into
devfrom
doc-sync/ownership-map-file-shares

Conversation

@ppenna

Copy link
Copy Markdown
Contributor

Summary

Correct two rows in the component responsibility map that still describe directory-only aggregate shares and treat every single share as a direct attachment.

The implementation now exports individual regular files without their parent directories. Keep this slice architectural: name the components and their contracts, and link to their implementations rather than copy code.

NVX base: 6020d5d49e2e4839feb46cbadbc8db7e8cf334e2.
Pinned OpenVMM: 2130f24b5a51561cc6224fe5a0aff93cb121ac32 (unchanged).

Changes

The map's previous edit pinned OpenVMM at 7bf0ee28b826374a2d386067df0456b81bcae818. The three commits through the current pin add regular-file children, explicit child kinds, and the required file flag. No code, gitlink, or public option changes are included.

Follow-ups

Validation

  • python -m unittest scripts.test_nvx_tools.CliTests scripts.test_performance.PerformanceTests — pass, 117 tests run, one skipped.
  • External throwaway Python checker, kept outside the repository — pass: all 22 relative links/anchors in the changed file and its incoming-link file resolve; the changed file has one H1 and balanced code fences; the design index links all 16 design chapters.
  • git diff --check — pass.
  • python scripts\nvx.py verify — pass, both before and after editing; the submodule checkout matches the recorded pin.
  • Full maintainer-style diff review — pass: one topic, one Markdown file, two lines added and two removed, claims checked against the pinned source and tests, no files touched by open PRs, and a clean submodule.
  • git verify-commit HEAD — pass using the repository's SSH signing configuration.

Reflect directory and regular-file children in the pinned OpenVMM filesystem contract, and clarify that even one file uses an aggregate. Link the responsible components to their implementation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 11, 2026 18:10
@ppenna Pedro Henrique Penna (ppenna) added the documentation Improvements or additions to documentation label Oct 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation accurately matches the pinned OpenVMM and NVX behavior.

0 open findings

What changed in this PR

Updates the component responsibility map to reflect regular-file host shares and aggregate attachment behavior.

Changes:

  • Documents directory and regular-file children in OpenVMM aggregates.
  • Clarifies when NVX uses direct versus aggregate attachments.
  • Links responsibilities to their implementations.
File Description
doc/​design/​code-ownership-map.md Corrects filesystem-sharing responsibilities and adds implementation links.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ppenna
Pedro Henrique Penna (ppenna) merged commit a5df986 into dev Oct 11, 2026
28 checks passed
@ppenna
Pedro Henrique Penna (ppenna) deleted the doc-sync/ownership-map-file-shares branch October 11, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants