Repository navigation
doc: add regular-file shares to the responsibility map - #489
Merged
Pedro Henrique Penna (ppenna) merged 1 commit intoOct 11, 2026
Merged
Conversation
Reflect directory and regular-file children in the pinned OpenVMM filesystem contract, and clarify that even one file uses an aggregate. Link the responsible components to their implementation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation accurately matches the pinned OpenVMM and NVX behavior.
0 open findings
What changed in this PR
Updates the component responsibility map to reflect regular-file host shares and aggregate attachment behavior.
Changes:
- Documents directory and regular-file children in OpenVMM aggregates.
- Clarifies when NVX uses direct versus aggregate attachments.
- Links responsibilities to their implementations.
| File | Description |
|---|---|
doc/design/code-ownership-map.md |
Corrects filesystem-sharing responsibilities and adds implementation links. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Pedro Henrique Penna (ppenna)
deleted the
doc-sync/ownership-map-file-shares
branch
October 11, 2026 22:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct two rows in the component responsibility map that still describe directory-only aggregate shares and treat every single share as a direct attachment.
The implementation now exports individual regular files without their parent directories. Keep this slice architectural: name the components and their contracts, and link to their implementations rather than copy code.
NVX base:
6020d5d49e2e4839feb46cbadbc8db7e8cf334e2.Pinned OpenVMM:
2130f24b5a51561cc6224fe5a0aff93cb121ac32(unchanged).Changes
python scripts\nvx.py run --help, andpython scripts\nvx.py sandbox provision --help.The map's previous edit pinned OpenVMM at
7bf0ee28b826374a2d386067df0456b81bcae818. The three commits through the current pin add regular-file children, explicit child kinds, and the required file flag. No code, gitlink, or public option changes are included.Follow-ups
Validation
python -m unittest scripts.test_nvx_tools.CliTests scripts.test_performance.PerformanceTests— pass, 117 tests run, one skipped.git diff --check— pass.python scripts\nvx.py verify— pass, both before and after editing; the submodule checkout matches the recorded pin.git verify-commit HEAD— pass using the repository's SSH signing configuration.