Repository navigation
Codify MXC agent and code-review guidance - #1519
Open
Branden Bonaby (bbonaby) wants to merge 1 commit into
Open
Branden Bonaby (bbonaby) wants to merge 1 commit into
Branden Bonaby (bbonaby) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1c5f0ea5-7586-4184-a1b2-e26c9ea00a2b
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation-only changes have no identified blocking defects and require no runtime tests.
No open issues 🎉
What changed in this PR
Codifies shared development and review expectations for MXC without changing runtime behavior or CI workflows.
Changes:
- Adds shared design, documentation, and testing guidance.
- Defines review checks for SDK compatibility, CI coverage, and containment.
- Connects contributor, Copilot, and Claude guidance.
| File | Description |
|---|---|
| CONTRIBUTING.md | Clarifies testing expectations and links shared guidance. |
| CLAUDE.md | Points Claude to shared instructions and review guidance. |
| AGENTS.md | Defines design, communication, and validation expectations. |
| .github/skills/mxc-code-review/SKILL.md | Adds repository-specific review checks. |
| .github/copilot-instructions.md | Links shared engineering and review guidance. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Documentation and agent instructions only; no runtime or CI workflow changes.
🔗 References
No linked issue.
🔍 Validation
git diff --check origin/main...user/bbonaby/codify-repo-instructions— passed.git rev-list --count origin/main..user/bbonaby/codify-repo-instructions— passed; one commit.✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see pull request builds)📋 Issue Type
GitHub Actions runs the PR validation build automatically. The ADO pipeline
(
MXC-PR-Build) is the Azure version of the PR pipeline, kept in parity with the GitHubActions build; it runs on merge to
main, and Microsoft reviewers with write access can trigger iton a PR with
/azp run. See pull request builds.If the
dependency-feed-checkcheck fails on a new dependency, the crate must be added tothe feed before the PR can pass. See pull request builds
for the steps.
Microsoft Reviewers: Open in CodeFlow