Skip to content

Fix IsolationSession bundle BinSkim failure #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dan Legg (danlegg) merged 1 commit into from
Oct 9, 2026
Merged

Fix IsolationSession bundle BinSkim failure #1456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .azure-pipelines/templates/IsolationSession.TestBundle.Build.Job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,21 @@ jobs:
Copy-Item "$sdkRoot/LICENSE.md" "$sdkStaged/LICENSE.md"
}
Copy-Item -Recurse "$sdkRoot/node_modules" "$sdkStaged/node_modules"

# node-pty ships third-party PDBs beside its prebuilt binaries. BinSkim
# reads their S_COMPILE3 records and reports BA2007 for upstream compiler
# switches, as it does for co-located Rust CRT PDBs. The symbols are not
# required to execute this test-only bundle, so keep the runtime binaries
# intact and omit only node-pty's PDBs.
$nodePtyPdbs = @(
Get-ChildItem -Path $sdkInteg -Filter '*.pdb' -Recurse -File |
Where-Object { $_.FullName -match '[\\/]node-pty[\\/]' }
)
foreach ($pdb in $nodePtyPdbs) {
Remove-Item -LiteralPath $pdb.FullName -Force -ErrorAction Stop
}
Write-Host " -> removed $($nodePtyPdbs.Count) node-pty PDB(s) from the test bundle"

Write-Host " -> sdk-integration/ (Node E2E suite)"

# Manifest
Expand Down
Loading