Repository navigation
Add Windows Sandbox E2E CI workflow with performance measurement - #126
Closed
Huzaifa Danish (huzaifa-d) wants to merge 4 commits into
Closed
Huzaifa Danish (huzaifa-d) wants to merge 4 commits into
Huzaifa Danish (huzaifa-d) wants to merge 4 commits into
Conversation
- Create .github/workflows/sandbox-e2e.yml modeled after microvm-e2e.yml - Graceful skip if Windows Sandbox feature is not enabled on runner - Rewrite run_sandbox_tests.ps1 with parameterized paths (-WxcExePath, -ConfigDir), per-test Stopwatch timing, and JSON perf output - Performance summary table printed in CI log - sandbox-perf-results.json uploaded as 30-day artifact - Passes --experimental flag (sandbox is experimental) - 45 min timeout (sandbox VM boot is slower than microvm) All 10 E2E tests pass locally with perf timing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use Out-File -Append instead of echo >> for pwsh compatibility. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dism may leave a non-zero LASTEXITCODE that pwsh propagates as step failure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Windows Sandbox feature reports Enabled on GitHub-hosted runners but WindowsSandbox.exe cannot boot VMs (no nested Hyper-V container support). Unlike NanVix/MicroVM which uses WHP (works on Azure VMs), Sandbox needs the full container infrastructure. - Added header comments explaining the limitation - Tests run with continue-on-error: true - Clear warning messages when tests fail on hosted runners - Workflow succeeds on self-hosted runners with full Sandbox support - Added if-no-files-found: ignore for artifact upload - Removed log upload step (no useful logs from failed sandbox boot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Needs a custom runner. Closing as not a priority ATM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a GitHub Actions workflow for sandbox E2E tests, modeled after the MicroVM E2E workflow from PR #123.
Workflow: .github/workflows/sandbox-e2e.yml\
un_sandbox_tests.ps1\
Test script updates: \ est_scripts/run_sandbox_tests.ps1\
un_nanvix_tests.ps1\ pattern
Note: Windows Sandbox likely NOT available on GitHub-hosted runners. Workflow will gracefully skip with a warning if the feature isn't enabled.
Microsoft Reviewers: Open in CodeFlow