Add PoliCheck banned-words validation for PR titles and descriptions - #11761
Open
Galina Paskaleva (gpaskaleva-msft) wants to merge 2 commits into
Open
Add PoliCheck banned-words validation for PR titles and descriptions#11761Galina Paskaleva (gpaskaleva-msft) wants to merge 2 commits into
Galina Paskaleva (gpaskaleva-msft) wants to merge 2 commits into
Conversation
…inUI-GitHub-PR pipeline
Galina Paskaleva (gpaskaleva-msft)
requested a review
from a team
as a code owner
September 2, 2026 08:27
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Author
|
/azp run |
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
Contributor
Author
|
/azp run |
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
Contributor
|
Re-queuing the build as a few extra service connections have been now disabled. |
Contributor
|
/azp run |
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
Harshit (harshit7962)
requested changes
Sep 2, 2026
Harshit (harshit7962)
left a comment
Contributor
There was a problem hiding this comment.
Still reviewing, posting single finding as of now
| displayName: Comment on PR about banned words | ||
| condition: and(succeeded(), eq(variables['needComment'], 'true')) | ||
| inputs: | ||
| gitHubConnection: 'WinUI' |
Contributor
There was a problem hiding this comment.
do we need to mention service connection explicitly? Also, this is not the service connection we use. Please check this again, ideally service connection should not be mentioned explicitly. Why is this needed? Also, if I am not wrong, this service connection was recently introduced, so why is it needed now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a validation stage to the PR pipeline that scans each pull request's title and description for words that should not be shared publicly. On a match, it posts a comment on the PR and fails the check.
An equivalent check was enforced before mainline development moved to GitHub; this restores that protection so PR titles and descriptions are guarded again.
Fixes #11730
What this introduces
A new
ValidatePrContentstage inbuild/WinUI-GitHub-PR.ymlthat runs on every PR:dotnet-maestro[bot]).Approach
Notes
Testing