Fixing codegen source - LatestVersion should be Experimental - #11751
Open
George Gao (gegao18) wants to merge 1 commit into
Open
Fixing codegen source - LatestVersion should be Experimental#11751George Gao (gegao18) wants to merge 1 commit into
George Gao (gegao18) wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Author
|
/azp run |
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
The codegen source
Microsoft.UI.Xaml.csis using the wrong WinUIContract value in its attributes. It should beWinUIContract.Experimentaland notWinUIContract.LatestVersion.Fixes #
PR Type
Description
The codegen source
Microsoft.UI.Xaml.cshas the wrong attribute value on the experimental DataTemplate ctors. It should beWinUIContract.Experimental(used inmain) and notWinUIContract.LatestVersion(used inrelease/...branches).I also noticed some whitespace diffs when running codegen locally, so I'm checkin in the updated generated .idl.
Current Behavior
LatestVersionis the enum value used in release branches.main's equivalent isExperimental.New Behavior
Same as before, but we're using the correct one now.
Customer Impact
N/A - this is codegen. The generated idl is already correct, but the source was wrong.
Regression Potential
How Has This Been Tested?
runcodegen.cmdnow passes.Screenshots (if appropriate)