Skip to content

Fixing codegen source - LatestVersion should be Experimental - #11751

Open
George Gao (gegao18) wants to merge 1 commit into
mainfrom
user/gegao18/DataTemplate-codegen
Open

Fixing codegen source - LatestVersion should be Experimental#11751
George Gao (gegao18) wants to merge 1 commit into
mainfrom
user/gegao18/DataTemplate-codegen

Conversation

@gegao18

Copy link
Copy Markdown
Contributor

Fixes

The codegen source Microsoft.UI.Xaml.cs is using the wrong WinUIContract value in its attributes. It should be WinUIContract.Experimental and not WinUIContract.LatestVersion.

Fixes #

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Description

The codegen source Microsoft.UI.Xaml.cs has the wrong attribute value on the experimental DataTemplate ctors. It should be WinUIContract.Experimental (used in main) and not WinUIContract.LatestVersion (used in release/... branches).

I also noticed some whitespace diffs when running codegen locally, so I'm checkin in the updated generated .idl.

Current Behavior

LatestVersion is the enum value used in release branches. main's equivalent is Experimental.

New Behavior

Same as before, but we're using the correct one now.

Customer Impact

N/A - this is codegen. The generated idl is already correct, but the source was wrong.

Regression Potential

  • Low risk — isolated change, limited scope
  • Medium risk — touches shared components or public APIs
  • High risk — architectural or breaking API change

How Has This Been Tested?

  • I have performed a self-review of my own code - runcodegen.cmd now passes.
  • I have added tests to cover my changes
  • Existing tests pass locally

Screenshots (if appropriate)

@gegao18
George Gao (gegao18) requested a review from a team as a code owner September 1, 2026 19:12
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@gegao18

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@microsoft-github-policy-service microsoft-github-policy-service Bot added the needs-triage Issue needs to be triaged by the area owners label Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-triage Issue needs to be triaged by the area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant