Repository navigation
Fix ContentDialog theme forwarding and default inheritance - #1389
Open
kusutoriクスとり (kusutori) wants to merge 1 commit into
Open
kusutoriクスとり (kusutori) wants to merge 1 commit into
kusutoriクスとり (kusutori) wants to merge 1 commit into
Conversation
kusutoriクスとり (kusutori)
requested a review
from Chris Anderson (codemonkeychris)
as a code owner
October 17, 2026 13:23
Collaborator
|
kusutoriクスとり (@kusutori) A couple of conflicts with main. |
kusutoriクスとり (kusutori)
force-pushed
the
fix/content-dialog-theme
branch
from
October 20, 2026 11:24
821861a to
d57a53f
Compare
Contributor
Author
|
Rebase is done and tests have passed. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward
.RequestedTheme(...)to the real ContentDialog instead of only its placeholder. When unset, follow the declaration site'sActualTheme, including live changes and local/multi-window overrides.The binding is detached on close/unmount. Explicit
Defaultremains explicit, native.Set(...)callbacks run last, and the guide documents the behavior. No new public API.Linked issue
Fixes #1388
Test plan
Real WinUI fixtures compare the visible dialog's theme and text foreground against a plain native ContentDialog. They cover Light/Dark/Default, both opening paths, live updates, override removal, secondary windows, draft preservation and teardown.
Removing initial forwarding, update forwarding or the theme-change subscription makes the corresponding tests fail. Framework Release build passed; Tonarink integration was also verified manually.
Risk / breaking changes
Unset dialogs now follow their declaration's effective theme rather than the application fallback. Targeted validation only, not the full solution/CI suite; ARM64 and combined AOT+MSIX were not tested locally.