Conversation
jairmyree
requested review from
KarishmaGhiya,
conniey,
Copilot,
jongio,
joshfree,
tmeschter,
vukelich and
wbreza
There was a problem hiding this comment.
Pull request overview
Updates Azure MCP Server documentation to better explain sovereign cloud usage (China/US Gov), including configuration and development guidance to avoid hardcoding public cloud endpoints.
Changes:
- Added “Sovereign Cloud Support” sections to the server README and troubleshooting guide, including configuration and authentication steps.
- Simplified
docs/sovereign-clouds.mdby removing “custom authority host” guidance and focusing on well-known sovereign clouds and aliases. - Expanded and renumbered
new-command.mdwith implementation guidelines for cloud-aware endpoint resolution (ARM vs data-plane SDKs).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| servers/Azure.Mcp.Server/docs/new-command.md | Adds sovereign-cloud-aware implementation guidance and renumbers sections. |
| servers/Azure.Mcp.Server/TROUBLESHOOTING.md | Adds troubleshooting guidance and pre-auth steps for sovereign clouds. |
| servers/Azure.Mcp.Server/README.md | Adds a discoverable sovereign cloud support section with usage examples. |
| docs/sovereign-clouds.md | Removes custom-authority-host docs and streamlines configuration examples. |
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
|
||
| ## Sovereign Cloud Support | ||
|
|
||
| Azure MCP Server supports connecting to Azure sovereign clouds. By default, it authenticates against the Azure Public Cloud. |
There was a problem hiding this comment.
Should mention that the aliases are case-insensitive
| |-------|---------| | ||
| | Azure Public Cloud | `AzureCloud`, `AzurePublicCloud`, `public` | | ||
| | Azure China Cloud | `AzureChinaCloud`, `china` | | ||
| | Azure US Government | `AzureUSGovernment`, `usgov` | |
There was a problem hiding this comment.
Not sure why the Copilot comment was resolved, we do have more aliases than this for Azure US Government
| | Cloud | Aliases | | ||
| |-------|---------| | ||
| | Azure Public Cloud | `AzureCloud`, `AzurePublicCloud`, `public` | | ||
| | Azure China Cloud | `AzureChinaCloud`, `china` | |
There was a problem hiding this comment.
From the comment on Azure US Government, should we add AzureChina as an allowed alias?
This pull request introduces comprehensive improvements for sovereign cloud support across documentation and implementation guidelines for the Azure MCP Server. The changes clarify how to configure and authenticate against Azure China and Azure US Government clouds, update best practices for SDK endpoint handling, and reorganize the command development documentation for clarity and completeness.
Sovereign Cloud Support Enhancements:
README.mdandTROUBLESHOOTING.mddescribing how to configure and authenticate against sovereign clouds, including supported aliases, authority hosts, and troubleshooting guidance. [1] [2]docs/sovereign-clouds.mdto remove custom authority host instructions, simplify client configuration examples, and focus on officially supported sovereign clouds and their aliases. [1] [2] [3] [4] [5]Implementation Guidelines for Sovereign Cloud Awareness:
new-command.mdwith a new section detailing how to ensure all services are cloud-aware, including explicit switch patterns for endpoint resolution and anti-patterns to avoid hardcoding public cloud endpoints. Reference implementations and rules are provided for both ARM and data plane SDKs.Documentation Structure Improvements:
new-command.mdto add and renumber sections, reflecting the new sovereign cloud support guidance and improving clarity for command, service, and test development. [1] [2] [3] [4] [5] [6] [7] [8]Navigation and Index Updates:
README.mdandTROUBLESHOOTING.mdfor easier discovery. [1] [2]These changes ensure the Azure MCP Server and its documentation are clear, robust, and ready for enterprise and government scenarios requiring sovereign cloud support.