Draft
Conversation
…ia constructor Co-authored-by: conniey <10136526+conniey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [microsoft/mcp#158] Refactor Azure.Mcp.Tools.Monitor for DI
DI Refactor: Azure.Mcp.Tools.Monitor
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
context.GetService<T>()usage from all Monitor commandExecuteAsyncimplementations, replacing with constructor-injected dependencies to improve testability and make dependencies explicit.Commands refactored
ActivityLogListCommand,ResourceLogQueryCommand,WorkspaceLogQueryCommand,TableListCommand,TableTypeListCommand,WorkspaceListCommand— now injectIMonitorServiceMetricsDefinitionsCommand,MetricsQueryCommand— now injectIMonitorMetricsServiceWebTestsCreateOrUpdateCommand,WebTestsGetCommand— now injectIMonitorWebTestServiceEntityGetHealthCommand— now injectsIMonitorHealthModelServiceBefore / After
Tests
Unit test constructors updated to pass mocked services directly to commands instead of registering them in a
ServiceCollection. Removed unusedMcpServerfield/import fromEntityGetHealthCommandTests.Invoking Livetests
Copilot submitted PRs are not trustworthy by default. Users with
writeaccess to the repo need to validate the contents of this PR before leaving a comment with the text/azp run mcp - pullrequest - live. This will trigger the necessary livetest workflows to complete required validation.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.