Add validations for DangerousIdentifiers#2074
Merged
xiangyan99 merged 1 commit intorelease/azure/1.xfrom Mar 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional safeguards to the PostgreSQL query tool by expanding the SQL validator to reject known dangerous PostgreSQL functions/system catalogs, and extends unit test coverage for these new blocked identifiers.
Changes:
- Added a
DangerousIdentifiersblocklist and token-level rejection inSqlQueryValidator. - Expanded
DatabaseQueryCommandTestsinvalid-query theory cases to cover additional dangerous functions/system catalogs. - Updated Azure MCP Server changelog to reflect the validator hardening.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Postgres/tests/Azure.Mcp.Tools.Postgres.UnitTests/Database/DatabaseQueryCommandTests.cs | Adds many new invalid-query cases to assert blocked dangerous identifiers return 400 and don’t hit the service. |
| tools/Azure.Mcp.Tools.Postgres/src/Validation/SqlQueryValidator.cs | Introduces and enforces a dangerous identifier blocklist during query tokenization. |
| servers/Azure.Mcp.Server/CHANGELOG.md | Notes the expanded PostgreSQL SQL validator blocklist in the Unreleased section. |
vcolin7
reviewed
Mar 17, 2026
Contributor
vcolin7
left a comment
There was a problem hiding this comment.
The changes look fine to me, but I'm curious about the Copilot feedback. Is it right to say the comment in the code is not accurate?
Member
Author
It seems to me just another way to describe it. :) |
vcolin7
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes]Add validations for DangerousIdentifiers
[Any additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabel/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline