Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Docker release flow to separate image loading/tagging from registry pushes and manifest publishing, aligning the pipeline with 1ES container push tasks.
Changes:
- Replaces the monolithic
Publish-DockerImages.ps1script withLoad-DockerImages.ps1(local load/tag) andPublish-DockerManifests.ps1(manifest creation/push). - Updates docker release pipeline to push per-architecture images via
1ES.PushContainerImage@1and then publish multi-arch manifests. - Updates
Prepare-Docker.ps1staging to include the new scripts for release-time execution.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eng/scripts/Publish-DockerManifests.ps1 | New script to create/push versioned + latest multi-arch manifests from already-pushed arch tags. |
| eng/scripts/Publish-DockerImages.ps1 | Removed old script that combined load/tag/push/manifest steps. |
| eng/scripts/Prepare-Docker.ps1 | Stages the new docker scripts into the docker staging artifact for 1ES release jobs. |
| eng/scripts/Load-DockerImages.ps1 | New script to load tarballs and apply predictable local tags for 1ES push tasks. |
| eng/pipelines/templates/jobs/docker/release-docker.yml | Updates release job to load locally, push arch images via 1ES tasks, then publish manifests. |
You can also share your feedback on Copilot code review. Take the survey.
conniey
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Take the single-script process of:
And split it into 3 steps:
GitHub issue number?
Fixes #1665
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabel/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline