fix: decode URL escapes before base64 data URI payloads - #2486
Draft
ADITYA (adity982) wants to merge 1 commit into
Draft
fix: decode URL escapes before base64 data URI payloads#2486ADITYA (adity982) wants to merge 1 commit into
ADITYA (adity982) wants to merge 1 commit into
Conversation
|
ADITYA (@adity982) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2481.
Decode URL escapes before base64-decoding a data URI's payload. Previously, a valid escaped payload could raise
binascii.Error(for exampleSGVsbG8%3D) or silently decode different bytes (%2B/8=producedd81ffcinstead offbff). The URL escaping applies to base64 payloads too: RFC 2397, section 3.This preserves raw
+characters (not form decoding), decodes escapes exactly once, and does not change MIME attributes or base64 validation policy. Add 18 regression cases covering padding, escaped plus/slash, partial escaping, lowercase escapes, metadata, non-base64 compatibility, Unicode and the public conversion API.Validation
cc0ca9edd8e23b2c7f7b778c7b148c1565730498.PYTHONUTF8=1,GITHUB_ACTIONS=true) and constrained[all]dependencies: 890 passed, 34 skipped. External/provider tests follow the repository's existing skip rules; no provider keys were supplied.git diff --checkpass.Validation boundaries: the initial run without CI settings had three Unicode CLI failures and one external speech-service assertion failure. The CLI failures disappear with the already-required UTF-8 setting; the speech failure independently reproduces in a clean, unchanged upstream worktree. The full repository type check reports 21 errors in 8 unchanged files, exactly matching the clean upstream baseline; it is not a passing type gate. The full hosted Python/OS matrix, OCR/MCP sibling packages and live external-provider behavior were not validated locally.